mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rajesh Shah <rajesh.shah@intel.com>
To: Adam Belay <abelay@novell.com>
Cc: Greg KH <greg@kroah.com>, Andrew Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz
Subject: Re: [PATCH 8/9] PCI PM: clear IO and MEM when disabling a device
Date: Mon, 5 Jun 2006 09:37:01 -0700	[thread overview]
Message-ID: <20060605093700.A10278@unix-os.sc.intel.com> (raw)
In-Reply-To: <1149497176.7831.162.camel@localhost.localdomain>; from abelay@novell.com on Mon, Jun 05, 2006 at 04:46:16AM -0400

On Mon, Jun 05, 2006 at 04:46:16AM -0400, Adam Belay wrote:
> This patch modifies pci_disable_device() to clear IO and MEM from the
> COMMAND PCI config register.  This is required before entering D3,  but
> also probably a good general practice for system suspend.
> 
I'd submitted a patch to do this about a month ago, see
http://marc.theaimsgroup.com/?l=linux-pci&m=114669552428309&w=2

That patch does the same thing, but in arch specific code (since
that's where memory and IO decode get enabled today). This patch
will cover the other arch's too, so I'm fine with this if this
is the right thing to do. My original patch is already in Greg's
tree and needs to be removed if this patch is accepted.

thanks,
Rajesh

  reply	other threads:[~2006-06-05 17:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-05  8:46 Adam Belay
2006-06-05 16:37 ` Rajesh Shah [this message]
2006-06-06  0:32 ` Benjamin Herrenschmidt
2006-06-07  3:16   ` Adam Belay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060605093700.A10278@unix-os.sc.intel.com \
    --to=rajesh.shah@intel.com \
    --cc=abelay@novell.com \
    --cc=akpm@osdl.org \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@atrey.karlin.mff.cuni.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome