From: Mario Limonciello <mario.limonciello@amd.com>
To: andy.shevchenko@gmail.com,
S-k Shyam-sundar <Shyam-sundar.S-k@amd.com>,
Natikar Basavaraj <Basavaraj.Natikar@amd.com>
Cc: linus.walleij@linaro.org, npliashechnikov@gmail.com,
nmschulte@gmail.com, friedrich.vock@gmx.de, dridri85@gmail.com,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] pinctrl: amd: Drop pull up select configuration
Date: Mon, 3 Jul 2023 21:13:09 -0500 [thread overview]
Message-ID: <1149e5fe-2106-9b8d-d104-6668339d30cf@amd.com> (raw)
In-Reply-To: <ZKM-U3aXGcXEgPLZ@surfacebook>
On 7/3/23 16:32, andy.shevchenko@gmail.com wrote:
> Fri, Jun 30, 2023 at 02:47:14PM -0500, Mario Limonciello kirjoitti:
>> pinctrl-amd currently tries to program bit 19 of all GPIOs to select
>> either a 4kΩ or 8hΩ pull up, but this isn't what bit 19 does. Bit
>> 19 is marked as reserved, even in the latest platforms documentation.
>>
>> Drop this programming functionality.
>
> Can it be that documentation is not (yet) updated?
>
No; I double checked documentation across products from last few years
as well as products to be coming out in the next few years and this bit
is consistently marked "Reserved".
> Where, btw, did the original code come from? Perhaps it may shed some light
> on this.
>
It's from the *very beginning* of the driver.
dbad75dd1f25 ("pinctrl: add AMD GPIO driver support.")
Original author isn't at AMD anymore, so I can't ask them.
I would guess that it was something that was discussed to be supported
but never actually was.
Maybe Shyam and Basavaraj have some other thoughts on this bit.
next prev parent reply other threads:[~2023-07-04 2:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-30 19:47 [PATCH 0/4] Fix for interrupt storm on ASUS TUF A16 Mario Limonciello
2023-06-30 19:47 ` [PATCH 1/4] pinctrl: amd: Only use special debounce behavior for GPIO 0 Mario Limonciello
2023-06-30 19:47 ` [PATCH 2/4] pinctrl: amd: Drop pull up select configuration Mario Limonciello
2023-07-03 21:32 ` andy.shevchenko
2023-07-04 2:13 ` Mario Limonciello [this message]
2023-06-30 19:47 ` [PATCH 3/4] pinctrl: amd: Unify debounce handling into amd_pinconf_set() Mario Limonciello
2023-07-03 21:33 ` andy.shevchenko
2023-07-04 2:16 ` Mario Limonciello
2023-06-30 19:47 ` [PATCH 4/4] pinctrl: amd: Use amd_pinconf_set() for all config options Mario Limonciello
2023-07-03 21:35 ` andy.shevchenko
2023-07-04 2:15 ` Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1149e5fe-2106-9b8d-d104-6668339d30cf@amd.com \
--to=mario.limonciello@amd.com \
--cc=Basavaraj.Natikar@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=andy.shevchenko@gmail.com \
--cc=dridri85@gmail.com \
--cc=friedrich.vock@gmx.de \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nmschulte@gmail.com \
--cc=npliashechnikov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome