* [Patch] Array overrun in drivers/net/wireless/wavelan.c
@ 2006-06-21 14:40 Eric Sesterhenn
0 siblings, 0 replies; only message in thread
From: Eric Sesterhenn @ 2006-06-21 14:40 UTC (permalink / raw)
To: linux-kernel; +Cc: jt
hi,
this is another array overrun spotted by coverity (#id 507)
we should check the index against array size before using it.
Not sure why the driver doesnt use ARRAY_SIZE instead of its
own macro.
Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
--- linux-2.6.17-git2/drivers/net/wireless/wavelan.c.orig 2006-06-21 16:35:19.000000000 +0200
+++ linux-2.6.17-git2/drivers/net/wireless/wavelan.c 2006-06-21 16:36:50.000000000 +0200
@@ -1695,8 +1695,8 @@ static int wv_frequency_list(unsigned lo
/* Look in the table if the frequency is allowed */
if (table[9 - (freq / 16)] & (1 << (freq % 16))) {
/* Compute approximate channel number */
- while ((((channel_bands[c] >> 1) - 24) < freq) &&
- (c < NELS(channel_bands)))
+ while ((c < NELS(channel_bands)) &&
+ (((channel_bands[c] >> 1) - 24) < freq))
c++;
list[i].i = c; /* Set the list index */
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2006-06-21 14:40 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-06-21 14:40 [Patch] Array overrun in drivers/net/wireless/wavelan.c Eric Sesterhenn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®