mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arjan van de Ven <arjan@infradead.org>
To: michal.k.k.piotrowski@gmail.com
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu, akpm@osdl.org,
	nagar@watson.ibm.com, balbir@in.ibm.com, jlan@engr.sgi.com
Subject: Re: + delay-accounting-taskstats-interface-send-tgid-once.patch added to -mm tree
Date: Tue, 27 Jun 2006 17:26:10 +0200	[thread overview]
Message-ID: <1151421970.5217.30.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <1151421336.5217.28.camel@laptopd505.fenrus.org>


> CPU 0                		CPU 1
> (in irq)            	 	(in the code above)

actually CPU 0 doesn't even have to be in irq context; any context will
do

> 		     		stats_lock is taken
> tasklist_lock is taken	     	
> stats_lock_is taken <spin>	
> 				<interrupt happens>
> 		     		tasklist_lock is taken
> 		     
> which now forms an AB-BA deadlock!
> 
> 
> this happens at least in copy_process which can call taskstats_tgid_free
> without first disabling interrupts (via cleanup_signal). There may be
> many other cases, I've not checked deeper yet.
> 
> Solution should be to make these functions use irqsave variant... any
> comments from the authors of this patch ?
> 
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/


  reply	other threads:[~2006-06-27 15:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200606261906.k5QJ6vCp025201@shell0.pdx.osdl.net>
2006-06-27 15:15 ` Arjan van de Ven
2006-06-27 15:26   ` Arjan van de Ven [this message]
2006-06-27 15:53   ` Shailabh Nagar
2006-06-27 16:06     ` Shailabh Nagar
2006-06-27 16:55       ` [PATCH] delay accounting taskstats interface: send tgid once locking fix Shailabh Nagar
2006-06-27 18:41         ` Michal Piotrowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1151421970.5217.30.camel@laptopd505.fenrus.org \
    --to=arjan@infradead.org \
    --cc=akpm@osdl.org \
    --cc=balbir@in.ibm.com \
    --cc=jlan@engr.sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.k.k.piotrowski@gmail.com \
    --cc=mingo@elte.hu \
    --cc=nagar@watson.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®