From: "Michal Piotrowski" <michal.k.k.piotrowski@gmail.com>
To: "Shailabh Nagar" <nagar@watson.ibm.com>
Cc: akpm@osdl.org, "Arjan van de Ven" <arjan@infradead.org>,
linux-kernel@vger.kernel.org, mingo@elte.hu, balbir@in.ibm.com,
jlan@engr.sgi.com
Subject: Re: [PATCH] delay accounting taskstats interface: send tgid once locking fix
Date: Tue, 27 Jun 2006 20:41:58 +0200 [thread overview]
Message-ID: <6bffcb0e0606271141o22077d69ya26fa6926e5524a1@mail.gmail.com> (raw)
In-Reply-To: <44A162F0.3060808@watson.ibm.com>
Hi,
On 27/06/06, Shailabh Nagar <nagar@watson.ibm.com> wrote:
> Use irqsave variants of spin_lock for newly introduced tsk->signal->stats_lock
> The lock is nested within tasklist_lock as part of release_task() and hence
> there is possibility of a AB-BA deadlock if a timer interrupt occurs while
> stats_lock is held.
>
> Thanks to Arjan van de Ven for pointing out the lock bug.
> The patch conservatively converts all use of stats_lock to irqsave variant
> rather than only the call within taskstats_tgid_free which is the function
> called within tasklist_lock protection.
>
> Signed-off-by: Shailabh Nagar <nagar@watson.ibm.com>
>
Problem solved, thanks.
Regards,
Michal
--
Michal K. K. Piotrowski
LTG - Linux Testers Group
(http://www.stardust.webpages.pl/ltg/wiki/)
prev parent reply other threads:[~2006-06-27 18:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200606261906.k5QJ6vCp025201@shell0.pdx.osdl.net>
2006-06-27 15:15 ` + delay-accounting-taskstats-interface-send-tgid-once.patch added to -mm tree Arjan van de Ven
2006-06-27 15:26 ` Arjan van de Ven
2006-06-27 15:53 ` Shailabh Nagar
2006-06-27 16:06 ` Shailabh Nagar
2006-06-27 16:55 ` [PATCH] delay accounting taskstats interface: send tgid once locking fix Shailabh Nagar
2006-06-27 18:41 ` Michal Piotrowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6bffcb0e0606271141o22077d69ya26fa6926e5524a1@mail.gmail.com \
--to=michal.k.k.piotrowski@gmail.com \
--cc=akpm@osdl.org \
--cc=arjan@infradead.org \
--cc=balbir@in.ibm.com \
--cc=jlan@engr.sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=nagar@watson.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®