Re: [PATCH 1/6] PCI-Express AER implemetation

["Zhang, Yanmin" <yanmin_zhang@linux.intel.com>]

On Fri, 2006-06-30 at 00:22, Grant Grundler wrote:
> Yanmin,
> Just one nit...
Thanks for your kind comments!

> 
> On Thu, Jun 29, 2006 at 09:12:27AM +0800, Zhang, Yanmin wrote:
> > Patch 1 consists of the pciaer-howto.txt document.
> ...
> > +In existing Linux kernels, 2.4.x and 2.6.x, there is no root service
> > +driver available to manage the PCI Express advanced error reporting
> > +extended capability structure.
> 
> "existing Linux kernels" won't mean anything 3 years.
> You might be more specific such as "All kernels before 2.6.18 released..."
I will change it.

> 
> 
> ...
> > +To provide a solution to these BIOS issues requires the PCI Express AER
> > +Root driver that provides:
> > +
> > +- 	A mechanism for the OS and application to determine if a fatal
> > +	error is fatal to the system, OS, or application increasing
> > +	uptime.
> 
> The word "mechanism" is used frequently.
> I wonder if sometimes (like above) "infrastructure" is meant.
I will change to 'infrastructure'.

> 
> > +8. Frequent Asked Questions
> 
> I'd be tempted to make the FAQ the next section after the introduction.
As a matter of fact, FAQ is complementarity to prior sections. If it is moved
just after the introduction, readers might be confused and I assume readers might
be unable to ask such questions before reading prior sections. :)