mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Grant Grundler <grundler@parisc-linux.org>
To: "Zhang, Yanmin" <yanmin_zhang@linux.intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	linux-pci maillist <linux-pci@atrey.karlin.mff.cuni.cz>,
	Tom Long Nguyen <tom.l.nguyen@intel.com>
Subject: Re: [PATCH 1/6] PCI-Express AER implemetation
Date: Thu, 29 Jun 2006 10:22:14 -0600	[thread overview]
Message-ID: <20060629162214.GB18767@colo.lackof.org> (raw)
In-Reply-To: <1151543547.28493.70.camel@ymzhang-perf.sh.intel.com>

Yanmin,
Just one nit...

On Thu, Jun 29, 2006 at 09:12:27AM +0800, Zhang, Yanmin wrote:
> Patch 1 consists of the pciaer-howto.txt document.
...
> +In existing Linux kernels, 2.4.x and 2.6.x, there is no root service
> +driver available to manage the PCI Express advanced error reporting
> +extended capability structure.

"existing Linux kernels" won't mean anything 3 years.
You might be more specific such as "All kernels before 2.6.18 released..."


...
> +To provide a solution to these BIOS issues requires the PCI Express AER
> +Root driver that provides:
> +
> +- 	A mechanism for the OS and application to determine if a fatal
> +	error is fatal to the system, OS, or application increasing
> +	uptime.

The word "mechanism" is used frequently.
I wonder if sometimes (like above) "infrastructure" is meant.

> +8. Frequent Asked Questions

I'd be tempted to make the FAQ the next section after the introduction.

hth,
grant

  parent reply	other threads:[~2006-06-29 16:22 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-29  1:12 Zhang, Yanmin
2006-06-29  1:18 ` [PATCH 2/6] " Zhang, Yanmin
2006-06-29  1:22   ` [PATCH 3/6] " Zhang, Yanmin
2006-06-29  1:30     ` [PATCH 4/6] " Zhang, Yanmin
2006-06-29  1:33       ` [PATCH 5/6] " Zhang, Yanmin
2006-06-29  1:41         ` [PATCH 6/6] " Zhang, Yanmin
2006-06-29 16:22 ` Grant Grundler [this message]
2006-06-30  1:28   ` [PATCH 1/6] " Zhang, Yanmin
2006-06-30  7:52     ` Zhang, Yanmin
2006-07-12  1:36 Zhang, Yanmin
2006-07-12  4:18 ` Greg KH
2006-07-12  5:07   ` Zhang, Yanmin
2006-07-12  4:20 ` Greg KH
2006-07-12  5:08   ` Zhang, Yanmin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060629162214.GB18767@colo.lackof.org \
    --to=grundler@parisc-linux.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@atrey.karlin.mff.cuni.cz \
    --cc=tom.l.nguyen@intel.com \
    --cc=yanmin_zhang@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®