From: Thomas Gleixner <tglx@linutronix.de>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: Andrew Morton <akpm@osdl.org>, Ingo Molnar <mingo@elte.hu>,
Christoph Lameter <clameter@sgi.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] IRQ: Use SA_PERCPU_IRQ, not IRQ_PER_CPU, for irqaction.flags
Date: Fri, 30 Jun 2006 21:23:21 +0200 [thread overview]
Message-ID: <1151695401.25491.759.camel@localhost.localdomain> (raw)
In-Reply-To: <200606301255.37638.bjorn.helgaas@hp.com>
On Fri, 2006-06-30 at 12:55 -0600, Bjorn Helgaas wrote:
> IRQ_PER_CPU is a bit in the struct irq_desc "status" field, not
> in the struct irqaction "flags", so the previous code checked the
> wrong bit.
>
> SA_PERCPU_IRQ is only used by drivers/char/mmtimer.c for SGI ia64 boxes.
>
> Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Doh, good catch.
Acked-by: Thomas Gleixner <tglx@linutronix.de>
prev parent reply other threads:[~2006-06-30 19:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-30 18:55 Bjorn Helgaas
2006-06-30 19:23 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1151695401.25491.759.camel@localhost.localdomain \
--to=tglx@linutronix.de \
--cc=akpm@osdl.org \
--cc=bjorn.helgaas@hp.com \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome