* [PATCH] IRQ: Use SA_PERCPU_IRQ, not IRQ_PER_CPU, for irqaction.flags
@ 2006-06-30 18:55 Bjorn Helgaas
2006-06-30 19:23 ` Thomas Gleixner
0 siblings, 1 reply; 2+ messages in thread
From: Bjorn Helgaas @ 2006-06-30 18:55 UTC (permalink / raw)
To: Andrew Morton
Cc: Ingo Molnar, Thomas Gleixner, Christoph Lameter, linux-kernel
IRQ_PER_CPU is a bit in the struct irq_desc "status" field, not
in the struct irqaction "flags", so the previous code checked the
wrong bit.
SA_PERCPU_IRQ is only used by drivers/char/mmtimer.c for SGI ia64 boxes.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Index: work-mm7/kernel/irq/manage.c
===================================================================
--- work-mm7.orig/kernel/irq/manage.c 2006-06-30 11:52:21.000000000 -0600
+++ work-mm7/kernel/irq/manage.c 2006-06-30 11:59:13.000000000 -0600
@@ -237,7 +237,8 @@
#if defined(CONFIG_IRQ_PER_CPU) && defined(SA_PERCPU_IRQ)
/* All handlers must agree on per-cpuness */
- if ((old->flags & IRQ_PER_CPU) != (new->flags & IRQ_PER_CPU))
+ if ((old->flags & SA_PERCPU_IRQ) !=
+ (new->flags & SA_PERCPU_IRQ))
goto mismatch;
#endif
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] IRQ: Use SA_PERCPU_IRQ, not IRQ_PER_CPU, for irqaction.flags
2006-06-30 18:55 [PATCH] IRQ: Use SA_PERCPU_IRQ, not IRQ_PER_CPU, for irqaction.flags Bjorn Helgaas
@ 2006-06-30 19:23 ` Thomas Gleixner
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Gleixner @ 2006-06-30 19:23 UTC (permalink / raw)
To: Bjorn Helgaas; +Cc: Andrew Morton, Ingo Molnar, Christoph Lameter, linux-kernel
On Fri, 2006-06-30 at 12:55 -0600, Bjorn Helgaas wrote:
> IRQ_PER_CPU is a bit in the struct irq_desc "status" field, not
> in the struct irqaction "flags", so the previous code checked the
> wrong bit.
>
> SA_PERCPU_IRQ is only used by drivers/char/mmtimer.c for SGI ia64 boxes.
>
> Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Doh, good catch.
Acked-by: Thomas Gleixner <tglx@linutronix.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-06-30 19:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-06-30 18:55 [PATCH] IRQ: Use SA_PERCPU_IRQ, not IRQ_PER_CPU, for irqaction.flags Bjorn Helgaas
2006-06-30 19:23 ` Thomas Gleixner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome