mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [HDRINSTALL 2/3] Remove asm/atomic.h from user visibility
       [not found] <1152573909.25567.45.camel@shinybook.infradead.org>
@ 2006-07-10 23:32 ` David Woodhouse
       [not found] ` <1152574110.25567.47.camel@shinybook.infradead.org>
  1 sibling, 0 replies; 2+ messages in thread
From: David Woodhouse @ 2006-07-10 23:32 UTC (permalink / raw)
  To: torvalds; +Cc: akpm, linux-kernel

[HDRINSTALL] Remove asm/atomic.h from user visibility
    
This isn't suitable for userspace to see -- the kernel headers are not a
random library of stuff for userspace; they're only there to define the
kernel<->user ABI for system libraries and tools. Anything which _was_
abusing asm/atomic.h from userspace was probably broken anyway -- as it
often didn't even give atomic operation.

Signed-off-by: David Woodhouse <dwmw2@infradead.org>

diff --git a/include/asm-generic/Kbuild.asm b/include/asm-generic/Kbuild.asm
index da163c1..bdb8b08 100644
--- a/include/asm-generic/Kbuild.asm
+++ b/include/asm-generic/Kbuild.asm
@@ -5,7 +5,7 @@ unifdef-y += a.out.h auxvec.h byteorder.
 	statfs.h termbits.h termios.h timex.h types.h unistd.h user.h
 
 # These really shouldn't be exported
-unifdef-y += atomic.h io.h
+unifdef-y += io.h
 
 # These probably shouldn't be exported
 unifdef-y += elf.h page.h

-- 
dwmw2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [HDRINSTALL 3/3] Remove asm/io.h from user visibility
       [not found] ` <1152574110.25567.47.camel@shinybook.infradead.org>
@ 2006-07-10 23:32   ` David Woodhouse
  0 siblings, 0 replies; 2+ messages in thread
From: David Woodhouse @ 2006-07-10 23:32 UTC (permalink / raw)
  To: torvalds; +Cc: akpm, linux-kernel

There's no excuse for userspace abusing this kernel header -- the
kernel's headers are not intended to provide a library of helper
routines for userspace. Using <asm/io.h> from userspace is broken on
most architectures anyway. Just say 'no'.

Signed-off-by: David Woodhouse <dwmw2@infradead.org>

diff --git a/include/asm-generic/Kbuild.asm b/include/asm-generic/Kbuild.asm
index bdb8b08..6b16dda 100644
--- a/include/asm-generic/Kbuild.asm
+++ b/include/asm-generic/Kbuild.asm
@@ -4,8 +4,5 @@ unifdef-y += a.out.h auxvec.h byteorder.
 	sigcontext.h siginfo.h signal.h socket.h sockios.h stat.h	\
 	statfs.h termbits.h termios.h timex.h types.h unistd.h user.h
 
-# These really shouldn't be exported
-unifdef-y += io.h
-
 # These probably shouldn't be exported
 unifdef-y += elf.h page.h

-- 
dwmw2


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-07-10 23:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <1152573909.25567.45.camel@shinybook.infradead.org>
2006-07-10 23:32 ` [HDRINSTALL 2/3] Remove asm/atomic.h from user visibility David Woodhouse
     [not found] ` <1152574110.25567.47.camel@shinybook.infradead.org>
2006-07-10 23:32   ` [HDRINSTALL 3/3] Remove asm/io.h " David Woodhouse

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®