From: Richard Purdie <rpurdie@rpsys.net>
To: Andrew Morton <akpm@osdl.org>
Cc: Claus Gindhart <claus.gindhart@kontron.com>,
Peter Korsgaard <jacmet@sunsite.dk>,
linux-kernel@vger.kernel.org
Subject: Fix ppc32 zImage inflate
Date: Thu, 20 Jul 2006 18:07:22 +0100 [thread overview]
Message-ID: <1153415243.5649.28.camel@localhost.localdomain> (raw)
ppc32's zImage inflates to address 0 which the recent zlib update took
as an error condition. Remove the check and note the problem so anyone
updating zlib in future won't fall into the same trap.
Reported-by: Peter Korsgaard <jacmet@sunsite.dk>
Reported-by: Claus Gindhart <claus.gindhart@kontron.com>
Signed-off-by: Richard Purdie <rpurdie@rpsys.net>
Index: git/lib/zlib_inflate/inflate.c
===================================================================
--- git.orig/lib/zlib_inflate/inflate.c 2006-07-15 09:11:07.000000000 +0100
+++ git/lib/zlib_inflate/inflate.c 2006-07-20 17:58:58.000000000 +0100
@@ -347,7 +347,10 @@
static const unsigned short order[19] = /* permutation of code lengths */
{16, 17, 18, 0, 8, 7, 9, 6, 10, 5, 11, 4, 12, 3, 13, 2, 14, 1, 15};
- if (strm == NULL || strm->state == NULL || strm->next_out == NULL ||
+ /* Do not check for strm->next_out == NULL here as ppc zImage
+ inflates to strm->next_out = 0 */
+
+ if (strm == NULL || strm->state == NULL ||
(strm->next_in == NULL && strm->avail_in != 0))
return Z_STREAM_ERROR;
reply other threads:[~2006-07-20 17:07 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1153415243.5649.28.camel@localhost.localdomain \
--to=rpurdie@rpsys.net \
--cc=akpm@osdl.org \
--cc=claus.gindhart@kontron.com \
--cc=jacmet@sunsite.dk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome