mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* Fix ppc32 zImage inflate
@ 2006-07-20 17:07 Richard Purdie
  0 siblings, 0 replies; only message in thread
From: Richard Purdie @ 2006-07-20 17:07 UTC (permalink / raw)
  To: Andrew Morton; +Cc: Claus Gindhart, Peter Korsgaard, linux-kernel

ppc32's zImage inflates to address 0 which the recent zlib update took
as an error condition. Remove the check and note the problem so anyone
updating zlib in future won't fall into the same trap.

Reported-by: Peter Korsgaard <jacmet@sunsite.dk>
Reported-by: Claus Gindhart <claus.gindhart@kontron.com>
Signed-off-by: Richard Purdie <rpurdie@rpsys.net>

Index: git/lib/zlib_inflate/inflate.c
===================================================================
--- git.orig/lib/zlib_inflate/inflate.c	2006-07-15 09:11:07.000000000 +0100
+++ git/lib/zlib_inflate/inflate.c	2006-07-20 17:58:58.000000000 +0100
@@ -347,7 +347,10 @@
     static const unsigned short order[19] = /* permutation of code lengths */
         {16, 17, 18, 0, 8, 7, 9, 6, 10, 5, 11, 4, 12, 3, 13, 2, 14, 1, 15};
 
-    if (strm == NULL || strm->state == NULL || strm->next_out == NULL ||
+    /* Do not check for strm->next_out == NULL here as ppc zImage
+       inflates to strm->next_out = 0 */
+
+    if (strm == NULL || strm->state == NULL ||
         (strm->next_in == NULL && strm->avail_in != 0))
         return Z_STREAM_ERROR;
 



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2006-07-20 17:07 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-07-20 17:07 Fix ppc32 zImage inflate Richard Purdie

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome