From: ricknu-0@student.ltu.se
To: linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@osdl.org>, Jeff Garzik <jeff@garzik.org>,
Alexey Dobriyan <adobriyan@gmail.com>,
Vadim Lobanov <vlobanov@speakeasy.net>,
Jan Engelhardt <jengelh@linux01.gwdg.de>,
Shorty Porty <getshorty_@hotmail.com>,
Peter Williams <pwil3058@bigpond.net.au>,
Michael Buesch <mb@bu3sch.de>,
Pekka Enberg <penberg@cs.helsinki.fi>,
Stefan Richter <stefanr@s5r6.in-berlin.de>,
larsbj@gullik.net
Subject: Re: [RFC][PATCH] A generic boolean (version 4)
Date: Sun, 23 Jul 2006 17:49:10 +0200 [thread overview]
Message-ID: <1153669750.44c39a7607a30@portal.student.luth.se> (raw)
In-Reply-To: <1153341500.44be983ca1407@portal.student.luth.se>
And here comes lucky number four.
Since there seems to be no case where _Bool is not defined (we uses only gcc >=
3), it got simplefied to just a:
typedef _Bool bool;
Hopefully it is now ready for a "real" patch, whom adds bool to all arches. If
there is no comments on this one, it will be sent about tomorrow night (GMT).
Signed-off-by: Richard Knutsson <ricknu-0@student.ltu.se>
---
drivers/block/DAC960.h | 2 +-
drivers/media/video/cpia2/cpia2.h | 4 ----
drivers/net/dgrs.c | 1 -
drivers/scsi/BusLogic.h | 5 +----
include/asm-i386/types.h | 2 ++
include/linux/stddef.h | 11 +++++++++++
6 files changed, 15 insertions(+), 10 deletions(-)
diff --git a/drivers/block/DAC960.h b/drivers/block/DAC960.h
index a82f37f..f9217c3 100644
--- a/drivers/block/DAC960.h
+++ b/drivers/block/DAC960.h
@@ -71,7 +71,7 @@ #define DAC690_V2_PciDmaMask 0xfffffffff
Define a Boolean data type.
*/
-typedef enum { false, true } __attribute__ ((packed)) boolean;
+typedef bool boolean;
/*
diff --git a/drivers/media/video/cpia2/cpia2.h b/drivers/media/video/cpia2/cpia2.h
index c5ecb2b..8d2dfc1 100644
--- a/drivers/media/video/cpia2/cpia2.h
+++ b/drivers/media/video/cpia2/cpia2.h
@@ -50,10 +50,6 @@ #define CPIA2_PATCH_VER 0
/***
* Image defines
***/
-#ifndef true
-#define true 1
-#define false 0
-#endif
/* Misc constants */
#define ALLOW_CORRUPT 0 /* Causes collater to discard checksum */
diff --git a/drivers/net/dgrs.c b/drivers/net/dgrs.c
index fa4f094..4dbc23d 100644
--- a/drivers/net/dgrs.c
+++ b/drivers/net/dgrs.c
@@ -110,7 +110,6 @@ static char version[] __initdata =
* DGRS include files
*/
typedef unsigned char uchar;
-typedef unsigned int bool;
#define vol volatile
#include "dgrs.h"
diff --git a/drivers/scsi/BusLogic.h b/drivers/scsi/BusLogic.h
index 9792e5a..d6d1d56 100644
--- a/drivers/scsi/BusLogic.h
+++ b/drivers/scsi/BusLogic.h
@@ -237,10 +237,7 @@ enum BusLogic_BIOS_DiskGeometryTranslati
Define a Boolean data type.
*/
-typedef enum {
- false,
- true
-} PACKED boolean;
+typedef bool boolean;
/*
Define a 10^18 Statistics Byte Counter data type.
diff --git a/include/asm-i386/types.h b/include/asm-i386/types.h
index 4b4b295..3cb84ac 100644
--- a/include/asm-i386/types.h
+++ b/include/asm-i386/types.h
@@ -1,6 +1,8 @@
#ifndef _I386_TYPES_H
#define _I386_TYPES_H
+typedef _Bool bool;
+
#ifndef __ASSEMBLY__
typedef unsigned short umode_t;
diff --git a/include/linux/stddef.h b/include/linux/stddef.h
index b3a2cad..f137815 100644
--- a/include/linux/stddef.h
+++ b/include/linux/stddef.h
@@ -10,6 +10,17 @@ #else
#define NULL ((void *)0)
#endif
+#undef false
+#undef true
+
+enum {
+ false = 0,
+ true = 1
+};
+
+#define false false
+#define true true
+
#undef offsetof
#ifdef __compiler_offsetof
#define offsetof(TYPE,MEMBER) __compiler_offsetof(TYPE,MEMBER)
next prev parent reply other threads:[~2006-07-23 15:50 UTC|newest]
Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-19 20:38 [RFC][PATCH] A generic boolean ricknu-0
2006-07-19 21:04 ` Jeff Garzik
2006-07-19 23:17 ` ricknu-0
2006-07-20 0:13 ` Jeff Garzik
2006-07-20 3:04 ` Vadim Lobanov
2006-07-20 3:53 ` Shorty Porty
2006-07-20 3:59 ` Dmitry Torokhov
2006-07-20 8:07 ` Jan Engelhardt
2006-08-04 14:03 ` Jes Sorensen
2006-08-04 14:42 ` Alan Cox
2006-08-04 14:35 ` Jes Sorensen
2006-08-04 15:51 ` Alan Cox
2006-08-04 15:58 ` Jes Sorensen
2006-08-04 16:00 ` Andreas Schwab
2006-08-04 16:08 ` Jes Sorensen
2006-08-04 16:16 ` Andreas Schwab
2006-08-04 16:26 ` Jes Sorensen
2006-08-04 16:57 ` Andreas Schwab
2006-08-04 18:47 ` Jes Sorensen
2006-08-04 18:51 ` H. Peter Anvin
2006-08-04 18:58 ` Jes Sorensen
2006-08-04 19:04 ` H. Peter Anvin
2006-08-06 9:25 ` Jan Engelhardt
2006-08-06 9:48 ` Andreas Schwab
2006-08-06 9:31 ` Jan Engelhardt
2006-08-06 15:31 ` Jes Sorensen
2006-08-04 16:30 ` Alan Cox
2006-08-04 16:20 ` Jes Sorensen
2006-07-19 21:20 ` Alexey Dobriyan
2006-07-19 22:47 ` ricknu-0
2006-07-19 23:52 ` Peter Williams
2006-07-20 0:08 ` ricknu-0
2006-07-20 8:09 ` Jan Engelhardt
2006-07-21 1:24 ` [RFC][PATCH] A generic boolean (version 2) ricknu-0
2006-07-21 1:34 ` Jeff Garzik
2006-07-21 8:55 ` Pekka Enberg
2006-07-21 21:14 ` Jeff Garzik
2006-07-25 19:04 ` Roman Kononov
2006-07-21 22:31 ` ricknu-0
2006-07-23 19:56 ` ricknu-0
2006-07-21 14:23 ` Jan Engelhardt
2006-07-21 18:27 ` Michael Buesch
2006-07-21 21:14 ` Jeff Garzik
2006-07-21 22:11 ` ricknu-0
2006-07-22 8:56 ` Jan Engelhardt
2006-07-21 23:08 ` [RFC][PATCH] A generic boolean (version 3) ricknu-0
2006-07-21 23:27 ` ricknu-0
2006-07-22 5:40 ` Stefan Richter
2006-07-22 17:08 ` ricknu-0
2006-07-22 18:08 ` Stefan Richter
2006-07-22 8:58 ` Jan Engelhardt
2006-07-22 17:19 ` ricknu-0
2006-07-22 9:55 ` Lars Gullik Bjønnes
2006-07-23 15:43 ` ricknu-0
2006-07-23 15:49 ` ricknu-0 [this message]
2006-07-23 16:08 ` [RFC][PATCH] A generic boolean (version 4) Jan Engelhardt
2006-07-23 19:36 ` ricknu-0
2006-07-23 20:26 ` Jeff Garzik
2006-07-23 20:25 ` Jeff Garzik
2006-07-23 21:17 ` Jan Engelhardt
2006-07-23 21:44 ` Jeff Garzik
2006-07-24 8:55 ` Paul Jackson
2006-07-23 16:13 ` Michael Buesch
2006-07-23 19:46 ` ricknu-0
2006-07-23 20:24 ` Jeff Garzik
2006-07-23 21:13 ` Paul Jackson
2006-07-25 23:22 ` [RFC][PATCH] A generic boolean (version 5) ricknu-0
2006-07-26 0:42 ` Paul Jackson
2006-07-26 20:28 ` [RFC][PATCH] A generic boolean (version 6) ricknu-0
2006-07-27 1:06 ` Paul Jackson
2006-07-27 2:10 ` Josef Sipek
2006-07-27 3:51 ` ricknu-0
2006-07-27 4:40 ` Josef Sipek
2006-07-27 4:00 ` Paul Jackson
2006-07-27 3:30 ` ricknu-0
2006-07-28 16:57 ` Jan Engelhardt
2006-07-27 2:48 ` Arnd Bergmann
2006-07-27 3:22 ` ricknu-0
2006-07-27 5:27 ` Nicholas Miell
2006-07-27 6:51 ` Paul Jackson
2006-07-27 19:55 ` ricknu-0
2006-07-27 20:13 ` Nicholas Miell
2006-07-28 1:29 ` ricknu-0
2006-07-28 1:56 ` Nicholas Miell
2006-07-28 12:50 ` Alan Cox
2006-07-28 20:24 ` Lars Noschinski
2006-07-28 21:31 ` Nicholas Miell
2006-07-27 19:46 ` [RFC][PATCH] A generic boolean (version 7) ricknu-0
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1153669750.44c39a7607a30@portal.student.luth.se \
--to=ricknu-0@student.ltu.se \
--cc=adobriyan@gmail.com \
--cc=akpm@osdl.org \
--cc=getshorty_@hotmail.com \
--cc=jeff@garzik.org \
--cc=jengelh@linux01.gwdg.de \
--cc=larsbj@gullik.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mb@bu3sch.de \
--cc=penberg@cs.helsinki.fi \
--cc=pwil3058@bigpond.net.au \
--cc=stefanr@s5r6.in-berlin.de \
--cc=vlobanov@speakeasy.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®