mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: ricknu-0@student.ltu.se
To: Josef Sipek <jsipek@fsl.cs.sunysb.edu>
Cc: Paul Jackson <pj@sgi.com>,
	linux-kernel@vger.kernel.org, akpm@osdl.org, jeff@garzik.org,
	adobriyan@gmail.com, vlobanov@speakeasy.net,
	jengelh@linux01.gwdg.de, getshorty_@hotmail.com,
	pwil3058@bigpond.net.au, mb@bu3sch.de, penberg@cs.helsinki.fi,
	stefanr@s5r6.in-berlin.de, larsbj@gullik.net
Subject: Re: [RFC][PATCH] A generic boolean (version 6)
Date: Thu, 27 Jul 2006 05:51:10 +0200	[thread overview]
Message-ID: <1153972270.44c8382ea9da5@portal.student.luth.se> (raw)
In-Reply-To: <20060727021047.GG28284@filer.fsl.cs.sunysb.edu>

Citerar Josef Sipek <jsipek@fsl.cs.sunysb.edu>:

> On Wed, Jul 26, 2006 at 06:06:22PM -0700, Paul Jackson wrote:
> > Richard wrote:
> > > * removed the #undef false/true and #define false/true
> > 
> > Good - thanks.
> > 
> > +enum {
> > +	false	= 0,
> > +	true	= 1
> > +};
> 
> You probably have said it before, but why do we need this?

Well Jeff, there is no _need_ for the false and true, but it makes the code more
readable to many of us. (Why else is there all these definitions of false and true?)
There is other opinions on this and that is one of the reason* bool isn't
defined as:

enum { false, true } bool;

letting us choose our own way.
So when (hopefully) the converting to these starts, it will only affect the
files already using some sort of false and true. If the author is more
comfortable with 0 and 1's, that will be respectet (by me, at least).

Hope it make some sense.

> Josef "Jeff" Sipek.

/Richard Knutsson

PS
If I got you wrong and you meant why it can't be defined where it is used, I
refere you to Andrew's mail "[patch 1/1] consolidate TRUE and FALSE", where a
redefinition occured (of TRUE/FALSE).
DS

* another is that C99 defines the boolean type for us (as _Bool).


  reply	other threads:[~2006-07-27  3:51 UTC|newest]

Thread overview: 88+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-19 20:38 [RFC][PATCH] A generic boolean ricknu-0
2006-07-19 21:04 ` Jeff Garzik
2006-07-19 23:17   ` ricknu-0
2006-07-20  0:13     ` Jeff Garzik
2006-07-20  3:04       ` Vadim Lobanov
2006-07-20  3:53         ` Shorty Porty
2006-07-20  3:59           ` Dmitry Torokhov
2006-07-20  8:07           ` Jan Engelhardt
2006-08-04 14:03   ` Jes Sorensen
2006-08-04 14:42     ` Alan Cox
2006-08-04 14:35       ` Jes Sorensen
2006-08-04 15:51         ` Alan Cox
2006-08-04 15:58           ` Jes Sorensen
2006-08-04 16:00             ` Andreas Schwab
2006-08-04 16:08               ` Jes Sorensen
2006-08-04 16:16                 ` Andreas Schwab
2006-08-04 16:26                   ` Jes Sorensen
2006-08-04 16:57                     ` Andreas Schwab
2006-08-04 18:47                       ` Jes Sorensen
2006-08-04 18:51                         ` H. Peter Anvin
2006-08-04 18:58                           ` Jes Sorensen
2006-08-04 19:04                             ` H. Peter Anvin
2006-08-06  9:25                   ` Jan Engelhardt
2006-08-06  9:48                     ` Andreas Schwab
2006-08-06  9:31                 ` Jan Engelhardt
2006-08-06 15:31                   ` Jes Sorensen
2006-08-04 16:30             ` Alan Cox
2006-08-04 16:20               ` Jes Sorensen
2006-07-19 21:20 ` Alexey Dobriyan
2006-07-19 22:47   ` ricknu-0
2006-07-19 23:52     ` Peter Williams
2006-07-20  0:08       ` ricknu-0
2006-07-20  8:09   ` Jan Engelhardt
2006-07-21  1:24 ` [RFC][PATCH] A generic boolean (version 2) ricknu-0
2006-07-21  1:34   ` Jeff Garzik
2006-07-21  8:55     ` Pekka Enberg
2006-07-21 21:14       ` Jeff Garzik
2006-07-25 19:04         ` Roman Kononov
2006-07-21 22:31     ` ricknu-0
2006-07-23 19:56     ` ricknu-0
2006-07-21 14:23   ` Jan Engelhardt
2006-07-21 18:27     ` Michael Buesch
2006-07-21 21:14       ` Jeff Garzik
2006-07-21 22:11         ` ricknu-0
2006-07-22  8:56       ` Jan Engelhardt
2006-07-21 23:08 ` [RFC][PATCH] A generic boolean (version 3) ricknu-0
2006-07-21 23:27 ` ricknu-0
2006-07-22  5:40   ` Stefan Richter
2006-07-22 17:08     ` ricknu-0
2006-07-22 18:08       ` Stefan Richter
2006-07-22  8:58   ` Jan Engelhardt
2006-07-22 17:19     ` ricknu-0
2006-07-22  9:55   ` Lars Gullik Bjønnes
2006-07-23 15:43     ` ricknu-0
2006-07-23 15:49 ` [RFC][PATCH] A generic boolean (version 4) ricknu-0
2006-07-23 16:08   ` Jan Engelhardt
2006-07-23 19:36     ` ricknu-0
2006-07-23 20:26       ` Jeff Garzik
2006-07-23 20:25     ` Jeff Garzik
2006-07-23 21:17       ` Jan Engelhardt
2006-07-23 21:44         ` Jeff Garzik
2006-07-24  8:55     ` Paul Jackson
2006-07-23 16:13   ` Michael Buesch
2006-07-23 19:46     ` ricknu-0
2006-07-23 20:24   ` Jeff Garzik
2006-07-23 21:13   ` Paul Jackson
2006-07-25 23:22 ` [RFC][PATCH] A generic boolean (version 5) ricknu-0
2006-07-26  0:42   ` Paul Jackson
2006-07-26 20:28 ` [RFC][PATCH] A generic boolean (version 6) ricknu-0
2006-07-27  1:06   ` Paul Jackson
2006-07-27  2:10     ` Josef Sipek
2006-07-27  3:51       ` ricknu-0 [this message]
2006-07-27  4:40         ` Josef Sipek
2006-07-27  4:00       ` Paul Jackson
2006-07-27  3:30     ` ricknu-0
2006-07-28 16:57     ` Jan Engelhardt
2006-07-27  2:48   ` Arnd Bergmann
2006-07-27  3:22     ` ricknu-0
2006-07-27  5:27     ` Nicholas Miell
2006-07-27  6:51       ` Paul Jackson
2006-07-27 19:55       ` ricknu-0
2006-07-27 20:13         ` Nicholas Miell
2006-07-28  1:29           ` ricknu-0
2006-07-28  1:56             ` Nicholas Miell
2006-07-28 12:50           ` Alan Cox
2006-07-28 20:24             ` Lars Noschinski
2006-07-28 21:31               ` Nicholas Miell
2006-07-27 19:46 ` [RFC][PATCH] A generic boolean (version 7) ricknu-0

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1153972270.44c8382ea9da5@portal.student.luth.se \
    --to=ricknu-0@student.ltu.se \
    --cc=adobriyan@gmail.com \
    --cc=akpm@osdl.org \
    --cc=getshorty_@hotmail.com \
    --cc=jeff@garzik.org \
    --cc=jengelh@linux01.gwdg.de \
    --cc=jsipek@fsl.cs.sunysb.edu \
    --cc=larsbj@gullik.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mb@bu3sch.de \
    --cc=penberg@cs.helsinki.fi \
    --cc=pj@sgi.com \
    --cc=pwil3058@bigpond.net.au \
    --cc=stefanr@s5r6.in-berlin.de \
    --cc=vlobanov@speakeasy.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®