From: Arjan van de Ven <arjan@linux.intel.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Jesper Juhl <jesper.juhl@gmail.com>,
linux-kernel@vger.kernel.org, reiser@namesys.com,
viro@zeniv.linux.org.uk, viro@ftp.linux.org.uk,
reiserfs-dev@namesys.com, reiserfs-list@namesys.com,
Ingo Molnar <mingo@elte.hu>
Subject: Re: [patch] lockdep: annotate vfs_rmdir for filesystems that take i_mutex in delete_inode
Date: Wed, 26 Jul 2006 08:38:28 +0200 [thread overview]
Message-ID: <1153895908.2896.6.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <1153895524.2896.2.camel@laptopd505.fenrus.org>
On Wed, 2006-07-26 at 08:32 +0200, Arjan van de Ven wrote:
> > The VFS takes the directory i_mutex and reiserfs_delete_inode() takes the
> > to-be-deleted file's i_mutex.
> >
> > That's notabug and lockdep will need to be taught about it.
>
> Actually the annotation is in vfs_rmdir() since that is where the parent
> is taken (this may sound odd but the I_MUTEX_* ordering rules require
> the parent taking to be annotated rather than the child)
Ignore this; this one is wrong, more later
next prev parent reply other threads:[~2006-07-26 6:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-25 22:16 possible recursive locking detected - while running fs operations in loops - 2.6.18-rc2-git5 Jesper Juhl
2006-07-25 23:29 ` Andreas Dilger
2006-07-29 22:18 ` Jesper Juhl
2006-07-29 23:08 ` Hans Reiser
2006-07-30 6:17 ` Jesper Juhl
2006-07-30 0:46 ` Hans Reiser
2006-07-30 10:08 ` Jesper Juhl
2006-07-31 19:34 ` Alexander Zarochentsev
2006-07-26 5:33 ` Andrew Morton
2006-07-26 6:32 ` [patch] lockdep: annotate vfs_rmdir for filesystems that take i_mutex in delete_inode Arjan van de Ven
2006-07-26 6:38 ` Arjan van de Ven [this message]
2006-07-26 6:47 ` Arjan van de Ven
2006-07-26 7:04 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1153895908.2896.6.camel@laptopd505.fenrus.org \
--to=arjan@linux.intel.com \
--cc=akpm@osdl.org \
--cc=jesper.juhl@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=reiser@namesys.com \
--cc=reiserfs-dev@namesys.com \
--cc=reiserfs-list@namesys.com \
--cc=viro@ftp.linux.org.uk \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®