mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] ide support for VIA 8237a southbridge
@ 2006-07-30 19:09 Diego Calleja
  2006-07-31 11:16 ` Alan Cox
  0 siblings, 1 reply; 2+ messages in thread
From: Diego Calleja @ 2006-07-30 19:09 UTC (permalink / raw)
  To: alan; +Cc: linux-kernel

Alan Cox added (622b20fcb8b42aa4c3c87c0a036f2ad0927b64bc) some PCI IDs 
for some VIA devices, including the 8237a. The driver, however, has not
been changed to support the 8237a, and someone reported it through
bugzilla (http://bugzilla.kernel.org/show_bug.cgi?id=6925)

So I'm taking the one-liner from:
http://forums.viaarena.com/messageview.aspx?catid=28&threadid=72836&enterthread=y
and submitting it. Please merge it if appropiate.



Signed-off-by: Diego Calleja <diegocg@gmail.com>

--- 2.6/drivers/ide/pci/via82cxxx.c.BUGGY	2006-07-30 20:55:18.000000000 +0200
+++ 2.6/drivers/ide/pci/via82cxxx.c	2006-07-30 21:03:25.000000000 +0200
@@ -6,7 +6,7 @@
  *
  *   vt82c576, vt82c586, vt82c586a, vt82c586b, vt82c596a, vt82c596b,
  *   vt82c686, vt82c686a, vt82c686b, vt8231, vt8233, vt8233c, vt8233a,
- *   vt8235, vt8237
+ *   vt8235, vt8237, vt8237a
  *
  * Copyright (c) 2000-2002 Vojtech Pavlik
  *
@@ -81,6 +81,7 @@ static struct via_isa_bridge {
 	{ "vt6410",	PCI_DEVICE_ID_VIA_6410,     0x00, 0x2f, VIA_UDMA_133 | VIA_BAD_AST },
 	{ "vt8251",	PCI_DEVICE_ID_VIA_8251,     0x00, 0x2f, VIA_UDMA_133 | VIA_BAD_AST },
 	{ "vt8237",	PCI_DEVICE_ID_VIA_8237,     0x00, 0x2f, VIA_UDMA_133 | VIA_BAD_AST },
+	{ "vt8237a",	PCI_DEVICE_ID_VIA_8237A,    0x00, 0x2f, VIA_UDMA_133 | VIA_BAD_AST },
 	{ "vt8235",	PCI_DEVICE_ID_VIA_8235,     0x00, 0x2f, VIA_UDMA_133 | VIA_BAD_AST },
 	{ "vt8233a",	PCI_DEVICE_ID_VIA_8233A,    0x00, 0x2f, VIA_UDMA_133 | VIA_BAD_AST },
 	{ "vt8233c",	PCI_DEVICE_ID_VIA_8233C_0,  0x00, 0x2f, VIA_UDMA_100 },

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] ide support for VIA 8237a southbridge
  2006-07-30 19:09 [PATCH] ide support for VIA 8237a southbridge Diego Calleja
@ 2006-07-31 11:16 ` Alan Cox
  0 siblings, 0 replies; 2+ messages in thread
From: Alan Cox @ 2006-07-31 11:16 UTC (permalink / raw)
  To: Diego Calleja; +Cc: alan, linux-kernel

Ar Sul, 2006-07-30 am 21:09 +0200, ysgrifennodd Diego Calleja:
> Alan Cox added (622b20fcb8b42aa4c3c87c0a036f2ad0927b64bc) some PCI IDs 
> for some VIA devices, including the 8237a. The driver, however, has not
> been changed to support the 8237a, and someone reported it through
> bugzilla (http://bugzilla.kernel.org/show_bug.cgi?id=6925)

The libata driver was, the change for the old driver was sent to the
maintainer on the same date. Ask Bartlomiej where it went.

> Signed-off-by: Diego Calleja <diegocg@gmail.com>

Acked-by: Alan Cox <alan@redhat.com>

> --- 2.6/drivers/ide/pci/via82cxxx.c.BUGGY	2006-07-30 20:55:18.000000000 +0200
> +++ 2.6/drivers/ide/pci/via82cxxx.c	2006-07-30 21:03:25.000000000 +0200
> @@ -6,7 +6,7 @@
>   *
>   *   vt82c576, vt82c586, vt82c586a, vt82c586b, vt82c596a, vt82c596b,
>   *   vt82c686, vt82c686a, vt82c686b, vt8231, vt8233, vt8233c, vt8233a,
> - *   vt8235, vt8237
> + *   vt8235, vt8237, vt8237a
>   *
>   * Copyright (c) 2000-2002 Vojtech Pavlik
>   *
> @@ -81,6 +81,7 @@ static struct via_isa_bridge {
>  	{ "vt6410",	PCI_DEVICE_ID_VIA_6410,     0x00, 0x2f, VIA_UDMA_133 | VIA_BAD_AST },
>  	{ "vt8251",	PCI_DEVICE_ID_VIA_8251,     0x00, 0x2f, VIA_UDMA_133 | VIA_BAD_AST },
>  	{ "vt8237",	PCI_DEVICE_ID_VIA_8237,     0x00, 0x2f, VIA_UDMA_133 | VIA_BAD_AST },
> +	{ "vt8237a",	PCI_DEVICE_ID_VIA_8237A,    0x00, 0x2f, VIA_UDMA_133 | VIA_BAD_AST },
>  	{ "vt8235",	PCI_DEVICE_ID_VIA_8235,     0x00, 0x2f, VIA_UDMA_133 | VIA_BAD_AST },
>  	{ "vt8233a",	PCI_DEVICE_ID_VIA_8233A,    0x00, 0x2f, VIA_UDMA_133 | VIA_BAD_AST },
>  	{ "vt8233c",	PCI_DEVICE_ID_VIA_8233C_0,  0x00, 0x2f, VIA_UDMA_100 },
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-07-31 10:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-07-30 19:09 [PATCH] ide support for VIA 8237a southbridge Diego Calleja
2006-07-31 11:16 ` Alan Cox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome