mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arjan van de Ven <arjan@infradead.org>
To: Andi Kleen <ak@muc.de>
Cc: Andrew Morton <akpm@osdl.org>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>, Greg KH <greg@kroah.com>,
	Andi Kleen <ak@suse.de>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [3/3] Support piping into commands in /proc/sys/kernel/core_pattern
Date: Fri, 18 Aug 2006 14:10:01 +0200	[thread overview]
Message-ID: <1155903001.4494.166.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <1155902485.4494.164.camel@laptopd505.fenrus.org>

On Fri, 2006-08-18 at 14:01 +0200, Arjan van de Ven wrote:
> On Fri, 2006-08-18 at 10:29 +0200, Andi Kleen wrote:
> > > But still.   Is this code secure?
> > 
> > Any auditing from third parties appreciated.
> > 
> > I don't know of any obvious flaws (at least assuming the pipe handler
> > isn't insecure code), but then I'm biased. 
> 
> one angle is... is the userspace handler trusted code by root? Or is it
> allowed to be per user/user defined binary? In the later case there are
> all kinds of DoS scenarios possible; in the former it's root doing that
> to himself ;)

so one angle that needs to be resolved is the selinux interaction, where
root!=root to some degree. If "any root" can control the sysctl, then
this could lead to information leaks, or worse, to a "limited root" to
"full root" escalation...

> 
-- 
if you want to mail me at work (you don't), use arjan (at) linux.intel.com


      reply	other threads:[~2006-08-18 12:10 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20060814 127.183332000@suse.de>
2006-08-14 11:27 ` [PATCH] [1/3] Some cleanup in the pipe code Andi Kleen
2006-08-14 11:27 ` [PATCH] [2/3] Create call_usermodehelper_pipe() Andi Kleen
2006-08-15 21:22   ` Andrew Morton
2006-08-16  2:13     ` Andrew Morton
2006-08-16  7:22       ` Andi Kleen
2006-08-14 11:27 ` [PATCH] [3/3] Support piping into commands in /proc/sys/kernel/core_pattern Andi Kleen
2006-08-15  0:43   ` Andrew Morton
2006-08-15  6:04     ` Andi Kleen
2006-08-16  8:43   ` Greg KH
2006-08-16  9:18     ` Andi Kleen
2006-08-16 18:10       ` Andrew Morton
2006-08-17  9:46         ` Andi Kleen
2006-08-17 11:27           ` Alan Cox
2006-08-18  5:30             ` Andrew Morton
2006-08-18  8:29               ` Andi Kleen
2006-08-18 12:01                 ` Arjan van de Ven
2006-08-18 12:10                   ` Arjan van de Ven [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1155903001.4494.166.camel@laptopd505.fenrus.org \
    --to=arjan@infradead.org \
    --cc=ak@muc.de \
    --cc=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®