From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: linux-pci maillist <linux-pci@atrey.karlin.mff.cuni.cz>
Cc: Greg KH <greg@kroah.com>,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: struct msix_entry bogosity
Date: Tue, 22 Aug 2006 15:49:22 +1000 [thread overview]
Message-ID: <1156225762.21752.82.camel@localhost.localdomain> (raw)
Any objection to something like that ? (And of course fixing the few
drivers for the name change)
struct msix_entry {
- u16 vector; /* kernel uses to write allocated vector */
+ unsigned int irq; /* kernel uses to write allocated
interrupt */
u16 entry; /* driver uses to specify entry, OS writes */
};
Maybe x86 has a 1:1 hw vector <-> linux irq numbers (does it btw ?) but
other archs certainly don't. pci_enable_msix API should return a linux
IRQ number for the driver to pass to request_irq(), certainly not a hw
vector number, and the normal type for an irq is unsigned int :)
If it's ok, I'll do a patch changing that and fixing all in-tree users.
Ben.
reply other threads:[~2006-08-22 5:49 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1156225762.21752.82.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®