mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* struct msix_entry bogosity
@ 2006-08-22  5:49 Benjamin Herrenschmidt
  0 siblings, 0 replies; only message in thread
From: Benjamin Herrenschmidt @ 2006-08-22  5:49 UTC (permalink / raw)
  To: linux-pci maillist; +Cc: Greg KH, Linux Kernel list

Any objection to something like that ? (And of course fixing the few
drivers for the name change)

 struct msix_entry {
-        u16     vector; /* kernel uses to write allocated vector */
+        unsigned int     irq; /* kernel uses to write allocated
interrupt */
         u16     entry;  /* driver uses to specify entry, OS writes */
 };

Maybe x86 has a 1:1 hw vector <-> linux irq numbers (does it btw ?) but
other archs certainly don't. pci_enable_msix API should return a linux
IRQ number for the driver to pass to request_irq(), certainly not a hw
vector number, and the normal type for an irq is unsigned int :)

If it's ok, I'll do a patch changing that and fixing all in-tree users.

Ben.





^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2006-08-22  5:49 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-08-22  5:49 struct msix_entry bogosity Benjamin Herrenschmidt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®