mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH for 2.6.18] spectrum_cs: Fix firmware uploading errors
@ 2006-08-22 17:55 Richard Purdie
  0 siblings, 0 replies; only message in thread
From: Richard Purdie @ 2006-08-22 17:55 UTC (permalink / raw)
  To: Jeff Garzik, Dominik Brodowski; +Cc: linux-kernel, Andrew Morton

spectrum_cs: Fix the logic so we error when the device is *not* present!

This fixes firmware upload failures which prevent the driver from
working (the bug is also present in 2.6.17).

Signed-off-by: Richard Purdie <rpurdie@rpsys.net>

---
 drivers/net/wireless/spectrum_cs.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6.17/drivers/net/wireless/spectrum_cs.c
===================================================================
--- linux-2.6.17.orig/drivers/net/wireless/spectrum_cs.c	2006-08-22 17:27:28.000000000 +0100
+++ linux-2.6.17/drivers/net/wireless/spectrum_cs.c	2006-08-22 17:27:58.000000000 +0100
@@ -245,7 +245,7 @@ spectrum_reset(struct pcmcia_device *lin
 	u_int save_cor;
 
 	/* Doing it if hardware is gone is guaranteed crash */
-	if (pcmcia_dev_present(link))
+	if (!pcmcia_dev_present(link))
 		return -ENODEV;
 
 	/* Save original COR value */



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2006-08-22 17:56 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-08-22 17:55 [PATCH for 2.6.18] spectrum_cs: Fix firmware uploading errors Richard Purdie

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®