mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@SteelEye.com>
To: "Darrick J. Wong" <djwong@us.ibm.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-scsi@vger.kernel.org, Alexis Bruemmer <alexisb@us.ibm.com>,
	Mike Anderson <andmike@us.ibm.com>,
	Konrad Rzeszutek <konrad@darnok.org>
Subject: Re: [PATCH] aic94xx: Increase can_queue and cmds_per_lun
Date: Wed, 30 Aug 2006 13:19:43 -0400	[thread overview]
Message-ID: <1156958383.7701.2.camel@mulgrave.il.steeleye.com> (raw)
In-Reply-To: <44F3CF6E.1070000@us.ibm.com>

On Mon, 2006-08-28 at 22:23 -0700, Darrick J. Wong wrote:
> -	.cmd_per_lun		= 1,
> +	.cmd_per_lun		= 2,

This is an old piece of code.  Today we use 1 for the cmd_per_lun of
non-TCQ devices.

> +	aic94xx_sht.can_queue = asd_ha->hw_prof.max_scbs - ASD_FREE_SCBS;

This is unnecessary unless you alter it before host alloc (which is
where it takes the shost values from the template).

Also, I think if you look at the rest of the driver, it's careful to
account for the need for required scbs in its internal queueing
algorithms, so the ASD_FREE_SCBS should be unnecessary.

> +	shost->can_queue = aic94xx_sht.can_queue;

James



  reply	other threads:[~2006-08-30 17:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-29  5:23 Darrick J. Wong
2006-08-30 17:19 ` James Bottomley [this message]
2006-08-30 19:03   ` Darrick J. Wong
2006-08-30 19:03   ` Darrick J. Wong
2006-08-30 19:04 ` Luben Tuikov
2006-08-30 19:25   ` James Bottomley
2006-08-31  5:29     ` Luben Tuikov
2006-08-30 20:55   ` [PATCH v3] aic94xx: Increase can_queue for better performance Darrick J. Wong
2006-08-30 21:18     ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1156958383.7701.2.camel@mulgrave.il.steeleye.com \
    --to=james.bottomley@steeleye.com \
    --cc=alexisb@us.ibm.com \
    --cc=andmike@us.ibm.com \
    --cc=djwong@us.ibm.com \
    --cc=konrad@darnok.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®