From: Shaohua Li <shaohua.li@intel.com>
To: kmannth@us.ibm.com
Cc: Bjorn Helgaas <bjorn.helgaas@hp.com>, Len Brown <lenb@kernel.org>,
"Moore, Robert" <robert.moore@intel.com>,
Mattia Dongili <malattia@linux.it>, Andrew Morton <akpm@osdl.org>,
lkml <linux-kernel@vger.kernel.org>,
linux acpi <linux-acpi@vger.kernel.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: one more ACPI Error (utglobal-0125): Unknown exception code:0xFFFFFFEA [Re: 2.6.18-rc4-mm3]
Date: Fri, 01 Sep 2006 10:39:06 +0800 [thread overview]
Message-ID: <1157078346.2782.24.camel@sli10-desk.sh.intel.com> (raw)
In-Reply-To: <1157073592.5649.29.camel@keithlap>
On Fri, 2006-09-01 at 09:19 +0800, keith mannthey wrote:
> On Thu, 2006-08-31 at 17:06 -0600, Bjorn Helgaas wrote:
> > On Thursday 31 August 2006 10:48, keith mannthey wrote:
> > > On Thu, 2006-08-31 at 02:48 -0400, Len Brown wrote:
> > > > On Tuesday 29 August 2006 16:04, Moore, Robert wrote:
> > > > > As far as the unknown exception,
> > > > >
> > > > > >[ 9.392729] [<c0246fb6>] acpi_ut_status_exit+0x31/0x5e
> > > > > >[ 9.393453] [<c0243352>] acpi_walk_resources+0x10e/0x11b
> > > > > >[ 9.394174] [<c025697e>] acpi_motherboard_add+0x22/0x31
> > > > >
> > > > > I would guess that the callback routine for walk_resources is
> returning
> > > > > a non-zero status value which is causing an immediate abort of
> the walk
> > > > > with that value -- and the value is bogus.
> > >
> > > Before I put this check in acpi_motherboard_add always attached
> itself
> > > to any resource type. I simply changed it so if the type is not
> > > ACPI_RESOURCE_TYPE_IO or ACPI_RESOURCE_TYPE_FIXED_IO it doesn't
> attach
> > > and can continue to find the correct device to attach to.
> > >
> > > Perhaps the motherboard device needs to attach to more device
> types?
> > >
> > > It was suggest by acpi folks to return -EINVAL. Should
> something else
> > > be returned?
> >
> > Problem 1: acpi_reserve_io_ranges() needs to return an acpi_status
> > like AE_OK or AE_CTRL_TERMINATE, not a -EINVAL.
>
> Sure great sounds. I understand AE_OK is a 0 return so I can change
> it
> to AE_CTRL_TERMINATE. I don't want acpi_reserve_io_ranges to return
> a
> happy state when if finds a resource type is doesn't know.
>
> > Problem 2: I don't understand how your patch works. An ACPI device
> > has a list of resources it uses. Are you saying that claiming all
> > the IO port resources of a PNP0C01 or PNP0C02 device causes the
> ACPI
> > memory hotplug driver to fail?
> >
> I don't know a whole heck of a lot about ACPI but let me try and
> explain the situation as best I can. I will attach my SSDT as well.
> Memory devices are PNP0C80.
>
> What the acpi_memory_device_driver is loaded in the system and you
> do
> a hot-add event the following call path takes place...
>
> acpi_memory_get_device
> acpi_bus_add
> acpi_add_single_object
> acpi_bus_find_driver
> acpi_bus_driver_init
> driver->ops.add
>
> The problem is the motherboard driver driver->ops.add is called
> before
> my memory device is scanned and it ALWASY returns AE_OK. Such that
> the
> device that is passed back up to that acpi_memory_get_device is NOT
> the
> memory_device_driver but this motherboard device and the add fails
> bigtime. I need acpi_find_bus_driver to return to me the
> acpi_memory_device_driver not the motherboard driver.
>
> It seems pretty sane to be to have the add
>
> > Is there some conflict between those PNP0C01 resources and the
> > resources of a hotplug memory device? Can you figure out exactly
> > what the conflict is by disassembling the DSDT for those devices?
>
> Kame (who helped me greatly in tracking down the source my troubles)
> thinks that the root cause is that the device (my memory_device) has
> both a _HID and _CID. The driver for _HID is different for _CID and
> the
> driver for _CID is found before _HID and I pass the wrong device up
> the
> chain.
>
> > We should understand this better before introducing special cases
> > to the motherboard driver. We should be able to trust the ACPI
> > description of the motherboard resources. The motherboard driver
> > currently claims only I/O port resources, but it really should
> > claim MMIO resources as well.
>
> The design of my patch is to make the motherboard driver return
> something other than 0 when it's driver->ops.add is called with
> resource
> types that are not what it expects.
>
> This way the scan if acpi_bus_find_driver will fine the correct acpi
> device.
>
> Also see
> http://sourceforge.net/mailarchive/forum.php?
> thread_id=15282420&forum_id=223
>
> I don't claim this is the ACPI correct solution and am welcome to any
> input that fixes my issue: acpi_bus_find_driver returning the
> incorrect
> driver for a given handle.
Then the issue is your device _CID returned PNP0C01 or PNP0C02. Is this
intended? Can we change the BIOS?
Thanks,
Shaohua
next prev parent reply other threads:[~2006-09-01 2:42 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-29 20:04 one more ACPI Error (utglobal-0125): Unknown exception code: 0xFFFFFFEA " Moore, Robert
2006-08-31 6:48 ` Len Brown
2006-08-31 16:48 ` keith mannthey
2006-08-31 23:06 ` Bjorn Helgaas
[not found] ` <1157073592.5649.29.camel@keithlap>
2006-09-01 2:39 ` Shaohua Li [this message]
2006-09-01 3:31 ` one more ACPI Error (utglobal-0125): Unknown exception code:0xFFFFFFEA " keith mannthey
2006-09-01 3:15 ` one more ACPI Error (utglobal-0125): Unknown exception code: 0xFFFFFFEA " Bjorn Helgaas
2006-09-01 3:56 ` KAMEZAWA Hiroyuki
2006-09-01 23:01 ` keith mannthey
2006-09-01 23:20 ` Bjorn Helgaas
2006-09-06 18:14 ` keith mannthey
-- strict thread matches above, loose matches on Subject: below --
2006-09-06 18:59 Moore, Robert
2006-09-06 20:04 ` keith mannthey
2006-09-07 2:03 ` one more ACPI Error (utglobal-0125): Unknown exception code:0xFFFFFFEA " Shaohua Li
2006-09-07 15:25 ` Bjorn Helgaas
2006-09-08 0:57 ` Shaohua Li
2006-09-08 2:27 ` Bjorn Helgaas
2006-09-13 1:27 ` keith mannthey
2006-09-13 14:51 ` Bjorn Helgaas
2006-09-14 3:01 ` Shaohua Li
2006-09-14 16:36 ` Bjorn Helgaas
2006-09-15 1:39 ` Shaohua Li
2006-09-19 10:22 ` Bjorn Helgaas
2006-09-14 17:55 ` keith mannthey
2006-09-15 1:52 ` Shaohua Li
2006-09-21 0:27 ` keith mannthey
2006-08-31 17:02 Moore, Robert
2006-08-31 17:56 ` keith mannthey
2006-08-29 2:05 one more ACPI Error (utglobal-0125): Unknown exception code: 0xFFFFFFEA " Li, Shaohua
2006-08-26 23:09 2.6.18-rc4-mm3 Andrew Morton
2006-08-28 20:24 ` one more ACPI Error (utglobal-0125): Unknown exception code: 0xFFFFFFEA [Re: 2.6.18-rc4-mm3] Mattia Dongili
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1157078346.2782.24.camel@sli10-desk.sh.intel.com \
--to=shaohua.li@intel.com \
--cc=akpm@osdl.org \
--cc=bjorn.helgaas@hp.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kmannth@us.ibm.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=malattia@linux.it \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®