From: "Bjorn Helgaas" <bjorn.helgaas@hp.com>
To: kmannth@us.ibm.com
Cc: "Bjorn Helgaas" <bjorn.helgaas@hp.com>,
"Len Brown" <lenb@kernel.org>,
"Moore, Robert" <robert.moore@intel.com>,
"Li, Shaohua" <shaohua.li@intel.com>,
"Mattia Dongili" <malattia@linux.it>,
"Andrew Morton" <akpm@osdl.org>,
"lkml" <linux-kernel@vger.kernel.org>,
"linux acpi" <linux-acpi@vger.kernel.org>,
"KAMEZAWA Hiroyuki" <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: one more ACPI Error (utglobal-0125): Unknown exception code: 0xFFFFFFEA [Re: 2.6.18-rc4-mm3]
Date: Thu, 31 Aug 2006 21:15:55 -0600 (MDT) [thread overview]
Message-ID: <49303.24.9.204.52.1157080555.squirrel@mail.cce.hp.com> (raw)
In-Reply-To: <1157073592.5649.29.camel@keithlap>
> On Thu, 2006-08-31 at 17:06 -0600, Bjorn Helgaas wrote:
>> Problem 1: acpi_reserve_io_ranges() needs to return an acpi_status
>> like AE_OK or AE_CTRL_TERMINATE, not a -EINVAL.
>
> Sure great sounds. I understand AE_OK is a 0 return so I can change it
> to AE_CTRL_TERMINATE. I don't want acpi_reserve_io_ranges to return a
> happy state when if finds a resource type is doesn't know.
Except that when the motherboard driver claims a device, it really
should claim all the resources used by the device. It currently only
claims I/O port resources, but I think it should also claim MMIO
resources. Otherwise, the system resource accounting is screwed up,
and resources consumed by the motherboard device could be mistakenly
allocated to another device.
> Kame (who helped me greatly in tracking down the source my troubles)
> thinks that the root cause is that the device (my memory_device) has
> both a _HID and _CID. The driver for _HID is different for _CID and the
> driver for _CID is found before _HID and I pass the wrong device up the
> chain.
Ok, this is starting to make sense. It sounds like your memory
device has _HID of PNP0C80 and _CID of PNP0C01 (or PNP0C02).
The current ACPI driver binding algorithm in acpi_bus_find_driver()
looks at each driver, checking whether it can match either the _HID
or the _CID of a device. Since we try the motherboard driver first,
it matches the memory device _CID.
I couldn't find a specific reference in the spec, but this seems
intuitively sub-optimal. It seems like it'd be better to look
first for a driver that can claim the _HID (which is more specific),
and only fall back to checking the _CIDs if no _HID-specific driver
is found.
This looks fairly easy to do in ACPI. Not so easy in PNPACPI,
since I don't think PNP has the concept of _HID vs _CID. Maybe
Len will chime in with an opinion.
Bjorn
next prev parent reply other threads:[~2006-09-01 3:20 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-29 20:04 Moore, Robert
2006-08-31 6:48 ` Len Brown
2006-08-31 16:48 ` keith mannthey
2006-08-31 23:06 ` Bjorn Helgaas
[not found] ` <1157073592.5649.29.camel@keithlap>
2006-09-01 2:39 ` one more ACPI Error (utglobal-0125): Unknown exception code:0xFFFFFFEA " Shaohua Li
2006-09-01 3:31 ` keith mannthey
2006-09-01 3:15 ` Bjorn Helgaas [this message]
2006-09-01 3:56 ` one more ACPI Error (utglobal-0125): Unknown exception code: 0xFFFFFFEA " KAMEZAWA Hiroyuki
2006-09-01 23:01 ` keith mannthey
2006-09-01 23:20 ` Bjorn Helgaas
2006-09-06 18:14 ` keith mannthey
-- strict thread matches above, loose matches on Subject: below --
2006-09-06 18:59 Moore, Robert
2006-09-06 20:04 ` keith mannthey
2006-09-07 2:03 ` one more ACPI Error (utglobal-0125): Unknown exception code:0xFFFFFFEA " Shaohua Li
2006-09-07 15:25 ` Bjorn Helgaas
2006-09-08 0:57 ` Shaohua Li
2006-09-08 2:27 ` Bjorn Helgaas
2006-09-13 1:27 ` keith mannthey
2006-09-13 14:51 ` Bjorn Helgaas
2006-09-14 3:01 ` Shaohua Li
2006-09-14 16:36 ` Bjorn Helgaas
2006-09-15 1:39 ` Shaohua Li
2006-09-19 10:22 ` Bjorn Helgaas
2006-09-14 17:55 ` keith mannthey
2006-09-15 1:52 ` Shaohua Li
2006-09-21 0:27 ` keith mannthey
2006-08-31 17:02 Moore, Robert
2006-08-31 17:56 ` keith mannthey
2006-08-29 2:05 one more ACPI Error (utglobal-0125): Unknown exception code: 0xFFFFFFEA " Li, Shaohua
2006-08-26 23:09 2.6.18-rc4-mm3 Andrew Morton
2006-08-28 20:24 ` one more ACPI Error (utglobal-0125): Unknown exception code: 0xFFFFFFEA [Re: 2.6.18-rc4-mm3] Mattia Dongili
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49303.24.9.204.52.1157080555.squirrel@mail.cce.hp.com \
--to=bjorn.helgaas@hp.com \
--cc=akpm@osdl.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kmannth@us.ibm.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=malattia@linux.it \
--cc=robert.moore@intel.com \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®