mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arjan van de Ven <arjan@infradead.org>
To: Miles Lane <miles.lane@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@osdl.org>,
	Herbert Xu <herbert@gondor.apana.org.au>
Subject: Re: 2.6.18-rc5-mm1 + all hotfixes -- INFO: possible recursive locking detected
Date: Wed, 06 Sep 2006 08:39:24 +0200	[thread overview]
Message-ID: <1157524765.29093.26.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <a44ae5cd0609051037k47d1ad7dsa8276dc0cec416bf@mail.gmail.com>

On Tue, 2006-09-05 at 10:37 -0700, Miles Lane wrote:
> ieee1394: Node changed: 0-01:1023 -> 0-00:1023
> ieee1394: Node changed: 0-02:1023 -> 0-01:1023
> ieee1394: Node suspended: ID:BUS[0-00:1023]  GUID[0080880002103eae]
> 
> =============================================
> [ INFO: possible recursive locking detected ]
> 2.6.18-rc5-mm1 #2
> ---------------------------------------------
> knodemgrd_0/2321 is trying to acquire lock:
>  (&s->rwsem){----}, at: [<f8958897>] nodemgr_probe_ne+0x311/0x38d [ieee1394]
> 
> but task is already holding lock:
>  (&s->rwsem){----}, at: [<f8959078>] nodemgr_host_thread+0x717/0x883 [ieee1394]


looks like a real bug to me:

nodemgr_node_probe() takes down_read(&class->subsys.rwsem) and then
calls nodemgr_probe_ne() which calls nodemgr_update_pdrv() which does
down_read(&class->subsys.rwsem).

Such recursive taking of rwsems is not allowed (rwsems are fair, if a
write comes in in between then there is a deadlock).



      parent reply	other threads:[~2006-09-06  6:39 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-05 17:37 Miles Lane
2006-09-05 18:13 ` Andrew Morton
2006-09-05 18:16   ` Miles Lane
2006-09-05 19:03     ` Stefan Richter
2006-09-05 19:19       ` Miles Lane
2006-09-05 19:51         ` Stefan Richter
2006-09-05 19:23   ` Stefan Richter
2006-09-05 21:07     ` Arjan van de Ven
2006-09-05 22:27       ` Stefan Richter
2006-09-06  0:10         ` Adrian Bunk
2006-09-06  7:13     ` Stefan Richter
2006-09-06 16:50       ` Stefan Richter
2006-09-06 17:04         ` [RFT PATCH 1/2] ieee1394: nodemgr: fix rwsem recursion Stefan Richter
2006-09-06 17:06           ` [RFT PATCH 2/2] ieee1394: nodemgr: grab class.subsys.rwsem in nodemgr_resume_ne Stefan Richter
2006-09-07 22:45         ` 2.6.18-rc5-mm1 + all hotfixes -- INFO: possible recursive locking detected Miles Lane
2006-09-07 23:23           ` Stefan Richter
2006-09-06 22:35       ` Greg KH
2006-09-05 19:49   ` Miles Lane
2006-09-05 20:19     ` Stefan Richter
2006-09-05 20:26       ` Stefan Richter
2006-09-05 20:33       ` Andrew Morton
2006-09-06  6:39 ` Arjan van de Ven [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1157524765.29093.26.camel@laptopd505.fenrus.org \
    --to=arjan@infradead.org \
    --cc=akpm@osdl.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miles.lane@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®