mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: linux1394-devel@lists.sourceforge.net
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
	Miles Lane <miles.lane@gmail.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Ben Collins <bcollins@ubuntu.com>, Greg KH <gregkh@suse.de>
Subject: [RFT PATCH 2/2] ieee1394: nodemgr: grab class.subsys.rwsem in nodemgr_resume_ne
Date: Wed, 6 Sep 2006 19:06:36 +0200 (CEST)	[thread overview]
Message-ID: <tkrat.249c4dbc1c15282d@s5r6.in-berlin.de> (raw)
In-Reply-To: <tkrat.a76041f4792feb5b@s5r6.in-berlin.de>

nodemgr_resume_ne was iterating over nodemgr_ud_class.children without
protection by nodemgr_ud_class.subsys.rwsem.

FIXME:
Shouldn't we rather use class->sem there, not class->subsys.rwsem?

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---
Index: linux/drivers/ieee1394/nodemgr.c
===================================================================
--- linux.orig/drivers/ieee1394/nodemgr.c	2006-09-06 18:34:35.000000000 +0200
+++ linux/drivers/ieee1394/nodemgr.c	2006-09-06 18:38:20.000000000 +0200
@@ -1352,6 +1352,7 @@ static void nodemgr_resume_ne(struct nod
 	ne->in_limbo = 0;
 	device_remove_file(&ne->device, &dev_attr_ne_in_limbo);
 
+	down_read(&nodemgr_ud_class.subsys.rwsem);
 	down_read(&ne->device.bus->subsys.rwsem);
 	list_for_each_entry(cdev, &nodemgr_ud_class.children, node) {
 		ud = container_of(cdev, struct unit_directory, class_dev);
@@ -1363,6 +1364,7 @@ static void nodemgr_resume_ne(struct nod
 			ud->device.driver->resume(&ud->device);
 	}
 	up_read(&ne->device.bus->subsys.rwsem);
+	up_read(&nodemgr_ud_class.subsys.rwsem);
 
 	HPSB_DEBUG("Node resumed: ID:BUS[" NODE_BUS_FMT "]  GUID[%016Lx]",
 		   NODE_BUS_ARGS(ne->host, ne->nodeid), (unsigned long long)ne->guid);



  reply	other threads:[~2006-09-06 17:07 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-05 17:37 2.6.18-rc5-mm1 + all hotfixes -- INFO: possible recursive locking detected Miles Lane
2006-09-05 18:13 ` Andrew Morton
2006-09-05 18:16   ` Miles Lane
2006-09-05 19:03     ` Stefan Richter
2006-09-05 19:19       ` Miles Lane
2006-09-05 19:51         ` Stefan Richter
2006-09-05 19:23   ` Stefan Richter
2006-09-05 21:07     ` Arjan van de Ven
2006-09-05 22:27       ` Stefan Richter
2006-09-06  0:10         ` Adrian Bunk
2006-09-06  7:13     ` Stefan Richter
2006-09-06 16:50       ` Stefan Richter
2006-09-06 17:04         ` [RFT PATCH 1/2] ieee1394: nodemgr: fix rwsem recursion Stefan Richter
2006-09-06 17:06           ` Stefan Richter [this message]
2006-09-07 22:45         ` 2.6.18-rc5-mm1 + all hotfixes -- INFO: possible recursive locking detected Miles Lane
2006-09-07 23:23           ` Stefan Richter
2006-09-06 22:35       ` Greg KH
2006-09-05 19:49   ` Miles Lane
2006-09-05 20:19     ` Stefan Richter
2006-09-05 20:26       ` Stefan Richter
2006-09-05 20:33       ` Andrew Morton
2006-09-06  6:39 ` Arjan van de Ven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tkrat.249c4dbc1c15282d@s5r6.in-berlin.de \
    --to=stefanr@s5r6.in-berlin.de \
    --cc=akpm@osdl.org \
    --cc=bcollins@ubuntu.com \
    --cc=gregkh@suse.de \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux1394-devel@lists.sourceforge.net \
    --cc=miles.lane@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®