From: David Woodhouse <dwmw2@infradead.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org
Subject: Re: [PATCH RFC]: New termios take 2
Date: Sun, 10 Sep 2006 11:46:20 +0100 [thread overview]
Message-ID: <1157885180.2977.133.camel@pmac.infradead.org> (raw)
In-Reply-To: <1157472883.9018.79.camel@localhost.localdomain>
On Tue, 2006-09-05 at 17:14 +0100, Alan Cox wrote:
> +
> +#define TCGETS2 _IOR('T',0x2A, struct termios)
> +#define TCSETS2 _IOW('T',0x2B, struct termios)
> +#define TCSETSW2 _IOW('T',0x2C, struct termios)
> +#define TCSETSF2 _IOW('T',0x2D, struct termios)
So existing code compiled against this will be using the new 'struct
termios' but the old TCGETS. Should we rename the existing ioctl to
TCGETS_OLD, and have TCGETS be the new one?
I suppose to a large extent it doesn't really matter as long as existing
C libraries happen to get it right -- and since the new structure only
has the new field added, the discrepancy shouldn't matter _too_ much.
But still...
--
dwmw2
next prev parent reply other threads:[~2006-09-10 10:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-05 16:14 Alan Cox
2006-09-10 10:46 ` David Woodhouse [this message]
2006-09-10 11:15 ` Alan Cox
2006-09-10 11:20 ` David Woodhouse
2006-09-10 12:24 ` Alan Cox
2006-09-10 13:06 ` David Woodhouse
2006-09-10 22:19 ` Arnd Bergmann
2006-09-11 10:13 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1157885180.2977.133.camel@pmac.infradead.org \
--to=dwmw2@infradead.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®