From: David Woodhouse <dwmw2@infradead.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org
Subject: Re: [PATCH RFC]: New termios take 2
Date: Sun, 10 Sep 2006 12:20:40 +0100 [thread overview]
Message-ID: <1157887240.2977.147.camel@pmac.infradead.org> (raw)
In-Reply-To: <1157886908.22571.11.camel@localhost.localdomain>
On Sun, 2006-09-10 at 12:15 +0100, Alan Cox wrote:
> Kernel headers are not intended for user space. In this case the struct
> termios presented by glibc already differs from the termios presented by
> the kernel so the problem doesn't arise at all.
Please note that we are moving away from the mindless repetition of that
phrase, and moving towards a system where we actually _mean_ it.
If you really don't want asm/term{bit,io}s.h to be visible in userspace,
then the way to express that is to provide a patch to
include/asm-generic/Kbuild which removes them from the export.
I don't think I agree -- I think these files _do_ provide part of the
kernel<->user ABI and should be kept. You're right that userspace in
_general_ shouldn't be touching them -- as I said, it's only really the
C libraries that are important here. As long as _they_ get it right when
built against the headers with your changes, we're fine.
But I don't think it's realistic to suggest that C libraries should be
built without access to our asm/term{bit,io}s.h at all. However, I'm
only really responsible for the new export _mechanism_ -- I'm not going
to impose policy except when people like Andi do stupid things and
sneakily send private patches to undo fixes I've already made.
So if you want to unexport those headers and make sure the C libraries
work like that, please do go ahead -- but don't just _say_ it, _do_ it
-- and please do make sure that at _least_ glibc still builds
afterwards.
--
dwmw2
next prev parent reply other threads:[~2006-09-10 11:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-05 16:14 Alan Cox
2006-09-10 10:46 ` David Woodhouse
2006-09-10 11:15 ` Alan Cox
2006-09-10 11:20 ` David Woodhouse [this message]
2006-09-10 12:24 ` Alan Cox
2006-09-10 13:06 ` David Woodhouse
2006-09-10 22:19 ` Arnd Bergmann
2006-09-11 10:13 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1157887240.2977.147.camel@pmac.infradead.org \
--to=dwmw2@infradead.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®