Re: [PATCH] namespaces: utsname: implement utsname namespaces

Re: [PATCH] namespaces: utsname: implement utsname namespaces

[David Woodhouse]

On Mon, 2006-10-02 at 16:01 +0000, Linux Kernel Mailing List wrote:
> commit 4865ecf1315b450ab3317a745a6678c04d311e40
> tree 6cf5d3028f8642eba2a8094eb413db080cc9219c
> parent 96b644bdec977b97a45133e5b4466ba47a7a5e65
> author Serge E. Hallyn <serue@us.ibm.com> 1159780694 -0700
> committer Linus Torvalds <torvalds@g5.osdl.org> 1159801041 -0700
> 
> [PATCH] namespaces: utsname: implement utsname namespaces
> 
> This patch defines the uts namespace and some manipulators.
> Adds the uts namespace to task_struct, and initializes a
> system-wide init namespace.
> 
> It leaves a #define for system_utsname so sysctl will compile.
> This define will be removed in a separate patch.

> --- a/include/linux/utsname.h
> +++ b/include/linux/utsname.h
> @@ -1,6 +1,11 @@
>  #ifndef _LINUX_UTSNAME_H
>  #define _LINUX_UTSNAME_H
>  
> +#include <linux/sched.h>
> +#include <linux/kref.h>
> +#include <linux/nsproxy.h>
> +#include <asm/atomic.h>
> +
>  #define __OLD_UTS_LEN 8

This patch was not tested with 'make headers_check':

usr/include/linux/utsname.h requires linux/kref.h, which does not exist in exported headers
usr/include/linux/utsname.h requires linux/nsproxy.h, which does not exist in exported headers
usr/include/linux/utsname.h requires asm/atomic.h, which does not exist in exported headers

Please protect stuff with #ifdef __KERNEL__ as appropriate, and remember
to run 'make headers_check' before submitting patches.

-- 
dwmw2

Re: [PATCH] namespaces: utsname: implement utsname namespaces

[David Woodhouse]

On Tue, 2006-10-03 at 09:57 +0100, David Woodhouse wrote:
> usr/include/linux/utsname.h requires linux/kref.h, which does not exist in exported headers
> usr/include/linux/utsname.h requires linux/nsproxy.h, which does not exist in exported headers
> usr/include/linux/utsname.h requires asm/atomic.h, which does not exist in exported headers 

We can probably just drop utsname.h from the export, since libc can't
use it as-is anyway. It doesn't actually define 'struct utsname'.

-- 
dwmw2