From: David Woodhouse <dwmw2@infradead.org>
To: Jeff Garzik <jeff@garzik.org>
Cc: Andrew Morton <akpm@osdl.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fs/jffs2: kill warning RE debug-only variables
Date: Wed, 04 Oct 2006 14:31:28 +0100 [thread overview]
Message-ID: <1159968688.20586.18.camel@pmac.infradead.org> (raw)
In-Reply-To: <20061004115718.GA22386@havoc.gtf.org>
On Wed, 2006-10-04 at 07:57 -0400, Jeff Garzik wrote:
> build:
>
> fs/jffs2/xattr.c: In function ‘unrefer_xattr_datum’:
> fs/jffs2/xattr.c:402: warning: unused variable ‘version’
> fs/jffs2/xattr.c:402: warning: unused variable ‘xid’
>
> Given that these variables are only used in the debug printk, and they
> merely remove a deref, we can easily kill the warning by adding the
> derefs to the debug printk.
>
> Signed-off-by: Jeff Garzik <jeff@garzik.org>
Applied; thanks.
--
dwmw2
prev parent reply other threads:[~2006-10-04 13:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-04 11:57 Jeff Garzik
2006-10-04 13:31 ` David Woodhouse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1159968688.20586.18.camel@pmac.infradead.org \
--to=dwmw2@infradead.org \
--cc=akpm@osdl.org \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®