From: Arjan van de Ven <arjan@infradead.org>
To: David Brownell <david-b@pacbell.net>
Cc: Andrew Morton <akpm@osdl.org>, Jeff Garzik <jeff@garzik.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] SPI: improve sysfs compiler complaint handling
Date: Thu, 12 Oct 2006 21:08:46 +0200 [thread overview]
Message-ID: <1160680127.3000.471.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <200610121146.09229.david-b@pacbell.net>
>
> > Who wrote all this stuff, and what were they thinking?
>
> I suspect what they were thinking was the old "if you can't figure out
> how to handle the error, don't test for it" thing.
the __must_check gcc feature was primarily designed to mark security
sensitive API's (such as copy_from_user) where you really do have to
check. Or cases where not checking/using is always a bug (realloc() in
userspace comes to mind).
It's OUR choice to mark the sysfs functions with this semantic, if we
don't want this strict warning we shouldn't use this attribute.
Based on many of the things that showed up so far, and Andrews comments,
I sort of get the feeling we DO want this behavior though...
next prev parent reply other threads:[~2006-10-12 19:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-12 1:49 Jeff Garzik
2006-10-12 18:08 ` David Brownell
2006-10-12 18:24 ` Andrew Morton
2006-10-12 18:46 ` David Brownell
2006-10-12 19:08 ` Arjan van de Ven [this message]
2006-10-12 18:39 ` Arjan van de Ven
2006-10-12 19:07 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1160680127.3000.471.camel@laptopd505.fenrus.org \
--to=arjan@infradead.org \
--cc=akpm@osdl.org \
--cc=david-b@pacbell.net \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®