From: Jeff Garzik <jeff@garzik.org>
To: dbrownell@users.sourceforge.net, Andrew Morton <akpm@osdl.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] SPI: improve sysfs compiler complaint handling
Date: Wed, 11 Oct 2006 21:49:20 -0400 [thread overview]
Message-ID: <20061012014920.GA13000@havoc.gtf.org> (raw)
Signed-off-by: Jeff Garzik <jeff@garzik.org>
---
Pointless? I leave it up to the maintainer(s) to decide.
The compiler complains, even with the "(void)".
drivers/spi/spi.c | 4 +++-
diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
index 146298a..085d4fa 100644
--- a/drivers/spi/spi.c
+++ b/drivers/spi/spi.c
@@ -448,7 +448,9 @@ static int __unregister(struct device *d
*/
void spi_unregister_master(struct spi_master *master)
{
- (void) device_for_each_child(master->cdev.dev, NULL, __unregister);
+ int dummy;
+
+ dummy = device_for_each_child(master->cdev.dev, NULL, __unregister);
class_device_unregister(&master->cdev);
}
EXPORT_SYMBOL_GPL(spi_unregister_master);
next reply other threads:[~2006-10-12 1:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-12 1:49 Jeff Garzik [this message]
2006-10-12 18:08 ` David Brownell
2006-10-12 18:24 ` Andrew Morton
2006-10-12 18:46 ` David Brownell
2006-10-12 19:08 ` Arjan van de Ven
2006-10-12 18:39 ` Arjan van de Ven
2006-10-12 19:07 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061012014920.GA13000@havoc.gtf.org \
--to=jeff@garzik.org \
--cc=akpm@osdl.org \
--cc=dbrownell@users.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®