From: Dave Kleikamp <shaggy@austin.ibm.com>
To: Eric L <e.codemonkey@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] lseek - SEEK_HOLE/SEEK_DATA support
Date: Tue, 17 Oct 2006 23:26:00 -0500 [thread overview]
Message-ID: <1161145562.23979.5.camel@kleikamp.austin.ibm.com> (raw)
In-Reply-To: <946a3fda0610171929m5b656be8r60c3e3241062ad27@mail.gmail.com>
On Tue, 2006-10-17 at 21:29 -0500, Eric L wrote:
> > vfs_lseek.patch:
> >
> > Can you add definititions of SEEK_HOLE and SEEK_DATA to fs.h? I really
> > don't like that the code doesn't use the symbolic constants.
> >
>
> Agreed. When I originally wrote it against 2.6.17.7, I couldn't find
> any precedent for adding such defines, but I see they are in 2.6.18.1
> at least.
Yeah, I realize the original code used 1 & 2, but this is a good
opportunity to improve that.
>
> Thanks for the comments. I've made these changes. Should I resubmit
> it to the mailing list (inline this time)?
Yeah, that would be great. You may get a bigger response if you cc'ed
linux-kernel@vger.kernel.org as well.
> - Eric
--
David Kleikamp
IBM Linux Technology Center
parent reply other threads:[~2006-10-18 4:26 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <946a3fda0610171929m5b656be8r60c3e3241062ad27@mail.gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1161145562.23979.5.camel@kleikamp.austin.ibm.com \
--to=shaggy@austin.ibm.com \
--cc=e.codemonkey@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®