* Re: [PATCH 1/1] lseek - SEEK_HOLE/SEEK_DATA support
[not found] ` <946a3fda0610171929m5b656be8r60c3e3241062ad27@mail.gmail.com>
@ 2006-10-18 4:26 ` Dave Kleikamp
0 siblings, 0 replies; only message in thread
From: Dave Kleikamp @ 2006-10-18 4:26 UTC (permalink / raw)
To: Eric L; +Cc: linux-kernel
On Tue, 2006-10-17 at 21:29 -0500, Eric L wrote:
> > vfs_lseek.patch:
> >
> > Can you add definititions of SEEK_HOLE and SEEK_DATA to fs.h? I really
> > don't like that the code doesn't use the symbolic constants.
> >
>
> Agreed. When I originally wrote it against 2.6.17.7, I couldn't find
> any precedent for adding such defines, but I see they are in 2.6.18.1
> at least.
Yeah, I realize the original code used 1 & 2, but this is a good
opportunity to improve that.
>
> Thanks for the comments. I've made these changes. Should I resubmit
> it to the mailing list (inline this time)?
Yeah, that would be great. You may get a bigger response if you cc'ed
linux-kernel@vger.kernel.org as well.
> - Eric
--
David Kleikamp
IBM Linux Technology Center
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2006-10-18 4:26 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <946a3fda0610161830u2070c903h7faa93d2dda3786f@mail.gmail.com>
[not found] ` <1161092211.14171.22.camel@kleikamp.austin.ibm.com>
[not found] ` <946a3fda0610171929m5b656be8r60c3e3241062ad27@mail.gmail.com>
2006-10-18 4:26 ` [PATCH 1/1] lseek - SEEK_HOLE/SEEK_DATA support Dave Kleikamp
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®