From: Trond Myklebust <Trond.Myklebust@netapp.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: torvalds@osdl.org, viro@ftp.linux.org.uk,
linux-kernel@vger.kernel.org, nfs@lists.sourceforge.net
Subject: Re: [PATCH 1/2] VFS: Make d_materialise_unique() enforce directory uniqueness
Date: Thu, 19 Oct 2006 17:00:38 -0400 [thread overview]
Message-ID: <1161291638.5506.9.camel@lade.trondhjem.org> (raw)
In-Reply-To: <E1GaerI-0007Af-00@dorka.pomaz.szeredi.hu>
On Thu, 2006-10-19 at 22:51 +0200, Miklos Szeredi wrote:
> > From: Trond Myklebust <Trond.Myklebust@netapp.com>
> >
> > If the caller tries to instantiate a directory using an inode that already
> > has a dentry alias, then we attempt to rename the existing dentry instead
> > of instantiating a new one. Fail with an ELOOP error if the rename would
> > affect one of our parent directories.
> >
> > This behaviour is needed in order to avoid issues such as
> >
> > http://bugzilla.kernel.org/show_bug.cgi?id=7178
> >
>
> This looks like a stale patch. You posted one on -fsdevel that did
> i_mutex locking as well.
Argh! Thanks for spotting that Miklos... I had forgotten to update my
'fixes' stgit branch with the newer version. Please discard the previous
version of this patch, Linus. I'll resend...
Cheers,
Trond
next prev parent reply other threads:[~2006-10-19 21:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-19 17:11 Trond Myklebust
2006-10-19 17:11 ` [PATCH 2/2] NFS: Cache invalidation fixup Trond Myklebust
2006-10-19 20:51 ` [PATCH 1/2] VFS: Make d_materialise_unique() enforce directory uniqueness Miklos Szeredi
2006-10-19 21:00 ` Trond Myklebust [this message]
2006-10-19 21:03 ` Trond Myklebust
2006-10-20 4:40 ` Andrew Morton
2006-10-20 4:54 ` Trond Myklebust
2006-10-19 21:03 ` [PATCH 2/2] NFS: Cache invalidation fixup Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1161291638.5506.9.camel@lade.trondhjem.org \
--to=trond.myklebust@netapp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=nfs@lists.sourceforge.net \
--cc=torvalds@osdl.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®