From: Trond Myklebust <Trond.Myklebust@netapp.com>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Al Viro <viro@ftp.linux.org.uk>,
linux-kernel@vger.kernel.org, nfs@lists.sourceforge.net
Subject: [PATCH 2/2] NFS: Cache invalidation fixup
Date: Thu, 19 Oct 2006 13:11:13 -0400 [thread overview]
Message-ID: <20061019171113.8593.90932.stgit@lade.trondhjem.org> (raw)
In-Reply-To: <20061019171113.8593.8585.stgit@lade.trondhjem.org>
From: Trond Myklebust <Trond.Myklebust@netapp.com>
If someone has renamed a directory on the server, triggering the d_move
code in d_materialise_unique(), then we need to invalidate the
cached directory information in the source parent directory.
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
---
fs/nfs/dir.c | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c
index 2cfa414..fa71936 100644
--- a/fs/nfs/dir.c
+++ b/fs/nfs/dir.c
@@ -936,8 +936,14 @@ static struct dentry *nfs_lookup(struct
no_entry:
res = d_materialise_unique(dentry, inode);
if (res != NULL) {
+ struct dentry *parent;
if (IS_ERR(res))
goto out_unlock;
+ /* Was a directory renamed! */
+ parent = dget_parent(res);
+ if (!IS_ROOT(parent))
+ nfs_mark_for_revalidate(parent->d_inode);
+ dput(parent);
dentry = res;
}
nfs_renew_times(dentry);
next prev parent reply other threads:[~2006-10-19 17:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-19 17:11 [PATCH 1/2] VFS: Make d_materialise_unique() enforce directory uniqueness Trond Myklebust
2006-10-19 17:11 ` Trond Myklebust [this message]
2006-10-19 20:51 ` Miklos Szeredi
2006-10-19 21:00 ` Trond Myklebust
2006-10-19 21:03 ` [PATCH 2/2] NFS: Cache invalidation fixup Trond Myklebust
2006-10-19 21:03 ` [PATCH 1/2] VFS: Make d_materialise_unique() enforce directory uniqueness Trond Myklebust
2006-10-20 4:40 ` Andrew Morton
2006-10-20 4:54 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061019171113.8593.90932.stgit@lade.trondhjem.org \
--to=trond.myklebust@netapp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nfs@lists.sourceforge.net \
--cc=torvalds@osdl.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®