* [PATCH 7/7] Char: isicom, check kmalloc retval
@ 2006-10-19 20:26 Jiri Slaby
2006-10-19 21:50 ` Alan Cox
0 siblings, 1 reply; 2+ messages in thread
From: Jiri Slaby @ 2006-10-19 20:26 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel
isicom, check kmalloc retval
Value returned from kamlloc may be NULL, we should check if ENOMEM occured.
Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
---
commit a026bdacd388dd774b6e6bd50dcb12adb10115f1
tree f729251fccf62c68dfc4e126574f2e1ee898a35a
parent b298d99f4a779fb54b0035f0f870d5247b13b269
author Jiri Slaby <jirislaby@gmail.com> Thu, 19 Oct 2006 19:47:29 +0200
committer Jiri Slaby <jirislaby@gmail.com> Thu, 19 Oct 2006 19:47:29 +0200
drivers/char/isicom.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/drivers/char/isicom.c b/drivers/char/isicom.c
index 2f5be09..a3d59a6 100644
--- a/drivers/char/isicom.c
+++ b/drivers/char/isicom.c
@@ -1708,6 +1708,11 @@ static int __devinit load_firmware(struc
}
data = kmalloc(word_count * 2, GFP_KERNEL);
+ if (data == NULL) {
+ dev_err(&pdev->dev, "Card%d, firmware upload "
+ "failed, not enough memory\n", index + 1);
+ goto errrelfw;
+ }
inw(base);
insw(base, data, word_count);
InterruptTheCard(base);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 7/7] Char: isicom, check kmalloc retval
2006-10-19 20:26 [PATCH 7/7] Char: isicom, check kmalloc retval Jiri Slaby
@ 2006-10-19 21:50 ` Alan Cox
0 siblings, 0 replies; 2+ messages in thread
From: Alan Cox @ 2006-10-19 21:50 UTC (permalink / raw)
To: Jiri Slaby; +Cc: Andrew Morton, linux-kernel
Ar Iau, 2006-10-19 am 22:26 +0200, ysgrifennodd Jiri Slaby:
> isicom, check kmalloc retval
>
> Value returned from kamlloc may be NULL, we should check if ENOMEM occured.
>
> Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Acked-by: Alan Cox <alan@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-10-19 21:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-10-19 20:26 [PATCH 7/7] Char: isicom, check kmalloc retval Jiri Slaby
2006-10-19 21:50 ` Alan Cox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome