From: Trond Myklebust <Trond.Myklebust@netapp.com>
To: Andrew Morton <akpm@osdl.org>
Cc: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nfs: Fix nfs_readpages() error path
Date: Sun, 29 Oct 2006 15:19:48 -0500 [thread overview]
Message-ID: <1162153188.5545.59.camel@lade.trondhjem.org> (raw)
In-Reply-To: <20061029121613.4fbc5c74.akpm@osdl.org>
On Sun, 2006-10-29 at 12:16 -0800, Andrew Morton wrote:
> On Sun, 29 Oct 2006 14:10:38 -0500
> Trond Myklebust <Trond.Myklebust@netapp.com> wrote:
>
> > Instead of the BUG_ON(), why can't we just stick a put_pages_list() into
> > __do_page_cache_readahead() and then get rid of all that duplicated
> > error handling in mpage_readpages(), nfs_readpages(), fuse_readpages(),
> > etc?
>
> I don't recall anything which would prevent that from being done. iirc it
> was one of those things which never happen. Then things changed and it
> happened once and was hence a special case. Then more things changed and
> it happened again, etc.
OK. I'll try to get round to doing it tomorrow (got to change to winter
tyres on my car today :-)).
Cheers,
Trond
next prev parent reply other threads:[~2006-10-29 20:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-29 15:56 OGAWA Hirofumi
2006-10-29 19:10 ` Trond Myklebust
2006-10-29 20:16 ` Andrew Morton
2006-10-29 20:19 ` Trond Myklebust [this message]
2006-10-29 20:40 ` OGAWA Hirofumi
2006-10-29 21:58 ` Trond Myklebust
2006-10-30 14:57 ` Steven Whitehouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1162153188.5545.59.camel@lade.trondhjem.org \
--to=trond.myklebust@netapp.com \
--cc=akpm@osdl.org \
--cc=hirofumi@mail.parknet.co.jp \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®