From: Trond Myklebust <Trond.Myklebust@netapp.com>
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, cluster-devel@redhat.com
Subject: Re: [PATCH] nfs: Fix nfs_readpages() error path
Date: Sun, 29 Oct 2006 16:58:06 -0500 [thread overview]
Message-ID: <1162159086.5545.70.camel@lade.trondhjem.org> (raw)
In-Reply-To: <87pscaua7p.fsf@duaron.myhome.or.jp>
On Mon, 2006-10-30 at 05:40 +0900, OGAWA Hirofumi wrote:
> Well, both seems right things for me. So, the patch was done by
> minimum change for -rc. If you want it, I'll do.
Feel free. I should have time to work on it tomorrow, in case you don't
find time today.
> BTW, umm.. now I think, gfs2_readpages() seems to have a bug in error
> path by different way. unlock_page() is really needed?
That looks like a definite bug too.
Cheers,
Trond
next prev parent reply other threads:[~2006-10-29 21:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-29 15:56 OGAWA Hirofumi
2006-10-29 19:10 ` Trond Myklebust
2006-10-29 20:16 ` Andrew Morton
2006-10-29 20:19 ` Trond Myklebust
2006-10-29 20:40 ` OGAWA Hirofumi
2006-10-29 21:58 ` Trond Myklebust [this message]
2006-10-30 14:57 ` Steven Whitehouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1162159086.5545.70.camel@lade.trondhjem.org \
--to=trond.myklebust@netapp.com \
--cc=akpm@osdl.org \
--cc=cluster-devel@redhat.com \
--cc=hirofumi@mail.parknet.co.jp \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®