mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] drivers/isdn/*: trivial vsnprintf() conversion
@ 2006-11-01  2:14 Alexey Dobriyan
  2006-11-01 12:33 ` Alan Cox
  0 siblings, 1 reply; 2+ messages in thread
From: Alexey Dobriyan @ 2006-11-01  2:14 UTC (permalink / raw)
  To: Andrew Morton; +Cc: linux-kernel

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---

 drivers/isdn/hardware/eicon/divasmain.c |    2 +-
 drivers/isdn/hisax/hisax_isac.c         |    2 +-
 drivers/isdn/hisax/st5481_d.c           |    4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)

--- a/drivers/isdn/hardware/eicon/divasmain.c
+++ b/drivers/isdn/hardware/eicon/divasmain.c
@@ -185,7 +185,7 @@ void diva_log_info(unsigned char *format
 	unsigned char line[160];
 
 	va_start(args, format);
-	vsprintf(line, format, args);
+	vsnprintf(line, sizeof(line), format, args);
 	va_end(args);
 
 	printk(KERN_INFO "%s: %s\n", DRIVERLNAME, line);
--- a/drivers/isdn/hisax/hisax_isac.c
+++ b/drivers/isdn/hisax/hisax_isac.c
@@ -433,7 +433,7 @@ static void l1m_debug(struct FsmInst *fi
 	char buf[256];
 	
 	va_start(args, fmt);
-	vsprintf(buf, fmt, args);
+	vsnprintf(buf, sizeof(buf), fmt, args);
 	DBG(DBG_L1M, "%s", buf);
 	va_end(args);
 }
--- a/drivers/isdn/hisax/st5481_d.c
+++ b/drivers/isdn/hisax/st5481_d.c
@@ -173,7 +173,7 @@ static void l1m_debug(struct FsmInst *fi
 	char buf[256];
 	
 	va_start(args, fmt);
-	vsprintf(buf, fmt, args);
+	vsnprintf(buf, sizeof(buf), fmt, args);
 	DBG(8, "%s", buf);
 	va_end(args);
 }
@@ -275,7 +275,7 @@ static void dout_debug(struct FsmInst *f
 	char buf[256];
 	
 	va_start(args, fmt);
-	vsprintf(buf, fmt, args);
+	vsnprintf(buf, sizeof(buf), fmt, args);
 	DBG(0x2, "%s", buf);
 	va_end(args);
 }


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] drivers/isdn/*: trivial vsnprintf() conversion
  2006-11-01  2:14 [PATCH] drivers/isdn/*: trivial vsnprintf() conversion Alexey Dobriyan
@ 2006-11-01 12:33 ` Alan Cox
  0 siblings, 0 replies; 2+ messages in thread
From: Alan Cox @ 2006-11-01 12:33 UTC (permalink / raw)
  To: Alexey Dobriyan; +Cc: Andrew Morton, linux-kernel

Ar Mer, 2006-11-01 am 05:14 +0300, ysgrifennodd Alexey Dobriyan:
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>

Not convinced they are neccessary but it is a good idea

Acked-by: Alan Cox <alan@redhat.com>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-11-01 12:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-11-01  2:14 [PATCH] drivers/isdn/*: trivial vsnprintf() conversion Alexey Dobriyan
2006-11-01 12:33 ` Alan Cox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome