From: Arjan van de Ven <arjan@infradead.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Conke Hu <conke.hu@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] add pci revision id to struct pci_dev
Date: Mon, 06 Nov 2006 15:19:17 +0100 [thread overview]
Message-ID: <1162822757.3138.32.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <1162819681.1566.63.camel@localhost.localdomain>
On Mon, 2006-11-06 at 13:28 +0000, Alan Cox wrote:
> Ar Llu, 2006-11-06 am 20:40 +0800, ysgrifennodd Conke Hu:
> > Hi all,
> > PCI revision id had better be added to struct pci_dev and
> > initialized in pci_scan_device.
>
> You can read the revision any time you like, we don't need to cache a
> copy as we don't reference it very often
one consideration is that if you read it from the hw you can't actually
fix it up in quirks at all, so it might make a lot of sense to just also
store it in the pci device struct, it's a very logical thing esp since
the pci device/vendor ids are stored there too (and those you can also
read from the hw if you want ;)
--
if you want to mail me at work (you don't), use arjan (at) linux.intel.com
Test the interaction between Linux and your BIOS via http://www.linuxfirmwarekit.org
next prev parent reply other threads:[~2006-11-06 14:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-06 12:40 Conke Hu
2006-11-06 12:46 ` Arjan van de Ven
2006-11-06 13:28 ` Alan Cox
2006-11-06 14:10 ` Conke Hu
2006-11-06 14:31 ` Alan Cox
2006-11-06 14:19 ` Arjan van de Ven [this message]
2006-11-06 14:34 ` Alan Cox
2006-11-06 21:01 ` Luca Tettamanti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1162822757.3138.32.camel@laptopd505.fenrus.org \
--to=arjan@infradead.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=conke.hu@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®