mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Conke Hu" <conke.hu@gmail.com>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] add pci revision id to struct pci_dev
Date: Mon, 6 Nov 2006 20:40:14 +0800	[thread overview]
Message-ID: <5767b9100611060440i1149e0e3v2162e0604db10da7@mail.gmail.com> (raw)

Hi all,
    PCI revision id had better be added to struct pci_dev and
initialized in pci_scan_device.

    Signed-off-by: Conke Hu <conke.hu@gmail.com>

-----
diff -Nur linux-2.6.19-rc4-git10.orig/drivers/pci/probe.c
linux-2.6.19-rc4-git10/drivers/pci/probe.c
--- linux-2.6.19-rc4-git10.orig/drivers/pci/probe.c     2006-11-06
19:38:43.000000000 +0800
+++ linux-2.6.19-rc4-git10/drivers/pci/probe.c  2006-11-06
19:41:17.000000000 +0800
@@ -785,6 +785,7 @@
       u32 l;
       u8 hdr_type;
       int delay = 1;
+       u8 rev;

       if (pci_bus_read_config_dword(bus, devfn, PCI_VENDOR_ID, &l))
               return NULL;
@@ -813,6 +814,9 @@
       if (pci_bus_read_config_byte(bus, devfn, PCI_HEADER_TYPE, &hdr_type))
               return NULL;

+       if (pci_bus_read_config_byte(bus, devfn, PCI_REVISION_ID, &rev))
+               return NULL;
+
       dev = kzalloc(sizeof(struct pci_dev), GFP_KERNEL);
       if (!dev)
               return NULL;
@@ -828,6 +832,7 @@
       dev->device = (l >> 16) & 0xffff;
       dev->cfg_size = pci_cfg_space_size(dev);
       dev->error_state = pci_channel_io_normal;
+       dev->revision = rev;

       /* Assume 32-bit PCI; let 64-bit PCI cards (which are far rarer)
          set this higher, assuming the system even supports it.  */
diff -Nur linux-2.6.19-rc4-git10.orig/include/linux/pci.h
linux-2.6.19-rc4-git10/include/linux/pci.h
--- linux-2.6.19-rc4-git10.orig/include/linux/pci.h     2006-11-06
19:39:07.000000000 +0800
+++ linux-2.6.19-rc4-git10/include/linux/pci.h  2006-11-06
19:41:57.000000000 +0800
@@ -123,6 +123,7 @@
       unsigned short  device;
       unsigned short  subsystem_vendor;
       unsigned short  subsystem_device;
+       u8              revision;       /* PCI revision ID */
       unsigned int    class;          /* 3 bytes: (base,sub,prog-if) */
       u8              hdr_type;       /* PCI header type (`multi'
flag masked out) */
       u8              rom_base_reg;   /* which config register
controls the ROM */

             reply	other threads:[~2006-11-06 12:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-06 12:40 Conke Hu [this message]
2006-11-06 12:46 ` Arjan van de Ven
2006-11-06 13:28 ` Alan Cox
2006-11-06 14:10   ` Conke Hu
2006-11-06 14:31     ` Alan Cox
2006-11-06 14:19   ` Arjan van de Ven
2006-11-06 14:34     ` Alan Cox
2006-11-06 21:01 ` Luca Tettamanti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5767b9100611060440i1149e0e3v2162e0604db10da7@mail.gmail.com \
    --to=conke.hu@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®