* Re: [BUG][REGRESSION] irda compile broken
[not found] <200611231023.34922.eike-kernel@sf-tec.de>
@ 2006-11-23 9:27 ` Peter Zijlstra
2006-11-23 19:55 ` David Miller
1 sibling, 0 replies; 2+ messages in thread
From: Peter Zijlstra @ 2006-11-23 9:27 UTC (permalink / raw)
To: Rolf Eike Beer
Cc: Ingo Molnar, Andrew Morton, David S.Miller, Linus Torvalds,
linux-kernel, Adrian Bunk
On Thu, 2006-11-23 at 10:23 +0100, Rolf Eike Beer wrote:
> Peter tried to fix a IRDA lockdep warning by commit
> 700f9672c9a61c12334651a94d17ec04620e1976. The commit message says: "it just
> needs a lockdep annotation."
>
> Compiling this gives:
>
> WARNING: "spin_lock_irqsave_nested" [net/irda/irda.ko] undefined!
>
> The only point in the whole kernel tree where spin_lock_irqsave_nested appears
> is in this file. Maybe this patch was meant to go into -mm and stay there?
The original mail also contained this:
(depends on patches in -mm for spin_lock_irqsave_nested())
Anyway, it has already been noticed, and Andrew will send the needed
bits upwards.
http://lkml.org/lkml/2006/11/22/283
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [BUG][REGRESSION] irda compile broken
[not found] <200611231023.34922.eike-kernel@sf-tec.de>
2006-11-23 9:27 ` [BUG][REGRESSION] irda compile broken Peter Zijlstra
@ 2006-11-23 19:55 ` David Miller
1 sibling, 0 replies; 2+ messages in thread
From: David Miller @ 2006-11-23 19:55 UTC (permalink / raw)
To: eike-kernel; +Cc: a.p.zijlstra, mingo, akpm, torvalds, linux-kernel, bunk
From: Rolf Eike Beer <eike-kernel@sf-tec.de>
Date: Thu, 23 Nov 2006 10:23:28 +0100
> Peter tried to fix a IRDA lockdep warning by commit
> 700f9672c9a61c12334651a94d17ec04620e1976. The commit message says: "it just
> needs a lockdep annotation."
>
> Compiling this gives:
>
> WARNING: "spin_lock_irqsave_nested" [net/irda/irda.ko] undefined!
>
> The only point in the whole kernel tree where spin_lock_irqsave_nested appears
> is in this file. Maybe this patch was meant to go into -mm and stay there?
As Andrew posted elsewhere, I accidently put that change in before the
infrastructure, and Andrew will push the necessary infrastructure
patch to Linus to fix this build failure.
Sorry for that, but it'll get fixed up soon.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-11-23 19:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <200611231023.34922.eike-kernel@sf-tec.de>
2006-11-23 9:27 ` [BUG][REGRESSION] irda compile broken Peter Zijlstra
2006-11-23 19:55 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®