From: Tengda Wu <wutengda@huaweicloud.com>
To: Namhyung Kim <namhyung@kernel.org>,
james.clark@linaro.org, xueshuai@linux.alibaba.com,
Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
leo.yan@linux.dev, Li Huafei <lihuafei1@huawei.com>,
Kim Phillips <kim.phillips@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Ingo Molnar <mingo@redhat.com>, Bill Wendling <morbo@google.com>,
Nick Desaulniers <nick.desaulniers+lkml@gmail.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Zecheng Li <zli94@ncsu.edu>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev
Subject: Re: [PATCH v6 25/26] perf annotate-arm64: Support per-cpu variable access tracking
Date: Sun, 20 Sep 2026 09:52:06 +0800 [thread overview]
Message-ID: <11700d47-ac92-487e-a20e-9fb2efa74534@huaweicloud.com> (raw)
In-Reply-To: <735c23b4a55db2c67be4920792922550ff4f6409.1789521520.git.wutengda@huaweicloud.com>
On 2026/9/16 9:30, Tengda Wu wrote:
> Extend update_insn_state_arm64() to handle per-cpu variable addressing.
>
> On arm64, per-cpu variables are accessed by adding a per-cpu offset
> (typically from the '__per_cpu_offset' array) to the address of a global
> variable or a structure field with '__percpu' modifier (e.g.,
> 's32 __percpu *counters' in struct percpu_counter). This results in
> instruction patterns like:
>
> ldr x0, [x6, x5] // Pattern A: direct load per-cpu instance
> add x0, x6, x5 // Pattern B: compute per-cpu address
>
> where x6 holds the per-cpu offset retrieved from:
>
> adrp x4, <page>
> add x4, x4, #offset // x4 = &__per_cpu_offset
> ldr x6, [x4, w0, sxtw #3] // x6 = __per_cpu_offset[cpu]
>
> and x5 is one of the following:
>
> case 1: global variable
> adrp x5, <page>
> add x5, x5, #offset // x5 = &global_var
>
> case 2: '__percpu' field embedded in a structure
> ldr x5, [x25, #32] // x5 = &percpu_field
>
> To handle such cases:
>
> 1. Identify per-cpu base initialization: Detect 'adrp + ldr' pairs that
> resolve to the '__per_cpu_offset' symbol and mark the destination
> register as TSR_KIND_PERCPU_BASE.
> 2. Propagate type information: During subsequent 'ldr' or 'add'
> instructions, if one register is TSR_KIND_PERCPU_BASE, attempt to
> resolve the type from the other register.
>
> A real-world example is shown below:
>
> ffff8000808f2d28 <cppc_set_perf>:
> ffff8000808f2d38: adrp x2, ffff800082033000
> ffff8000808f2d3c: add x5, x2, #0x3f8 // x5 = &__per_cpu_offset
> ffff8000808f2d44: adrp x2, ffff800081f73000
> ffff8000808f2d48: add x2, x2, #0x6b8 // x2 = &cpu_pcc_subspace_idx
> ffff8000808f2d6c: ldr x5, [x5, w0, sxtw #3] // x5 = __per_cpu_offset[cpu]
> * ffff8000808f2d80: ldr w23, [x5, x2] // per_cpu_var(cpu_pcc_subspace_idx)
>
> Before this commit, the tracker could not link x5 back to a per-cpu
> context, resulting in an incorrect data type resolution:
>
> adrp [10] global addr=0xffff800082033000 -> reg2
> add [14] global 0x3f8(reg2) -> reg5
> adrp [1c] global addr=0xffff800081f73000 -> reg2
> add [20] global 0x6b8(reg2) -> reg2
> ldr [44] global (reg5, reg0) -> reg5 type='long unsigned int[]' size=0x1000
> chk [58] reg5 offset=0 ok=1 kind=1 (long unsigned int[]) : Good!
> found by insn track: 0(reg5, reg2) type-offset=0
> final result: type='long unsigned int' size=0x8
>
> After this commit, the tracker correctly identifies the per-cpu flow and
> resolves the actual variable type:
>
> ldr [44] global (reg5, reg0) -> reg5 percpu base
> chk [58] reg5 offset=0 ok=1 kind=2 percpu var : retry
> chk [58] reg2 offset=0 ok=1 kind=7 global addr : Good!
> found by insn track: 0(reg5, reg2) type-offset=0
> final result: type='int' size=0x4
>
> Signed-off-by: Tengda Wu <wutengda@huaweicloud.com>
> ---
> .../perf/util/annotate-arch/annotate-arm64.c | 47 ++++++++++++++++++-
> tools/perf/util/annotate-data.c | 22 ++++++++-
> 2 files changed, 67 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/util/annotate-arch/annotate-arm64.c b/tools/perf/util/annotate-arch/annotate-arm64.c
> index b25a3c70675c..f4b7b0eb44f4 100644
> --- a/tools/perf/util/annotate-arch/annotate-arm64.c
> +++ b/tools/perf/util/annotate-arch/annotate-arm64.c
> @@ -12,6 +12,7 @@
> #include "../disasm.h"
> #include "../annotate-data.h"
> #include "../debug.h"
> +#include "../dso.h"
> #include "../map.h"
> #include "../symbol.h"
>
> @@ -643,13 +644,23 @@ static int propagate_load_reg_state(struct type_state *state,
> u64 ip = dloc->ms->sym->start + dl->al.offset;
> u64 addr = src_tsr->imm_value + reg_offset;
> int offset;
> + u8 kind;
> + const char *var_name = NULL;
> +
> + /* it might be per-cpu offset */
> + if (dso__kernel(map__dso(dloc->ms->map)) &&
> + get_global_var_info(dloc, addr, &var_name, &offset) &&
> + !strcmp(var_name, "__per_cpu_offset"))
> + kind = TSR_KIND_PERCPU_BASE;
> + else
> + kind = TSR_KIND_TYPE;
>
> if (!get_global_var_type(cu_die, dloc, ip, addr, &offset, &type_die) ||
> !die_get_member_type(&type_die, offset, &type_die))
> return -1;
>
> tsr->type = type_die;
> - tsr->kind = TSR_KIND_TYPE;
> + tsr->kind = kind;
> tsr->offset = 0;
> tsr->imm_value = 0;
> tsr->ok = true;
> @@ -666,6 +677,12 @@ static int propagate_load_reg_state(struct type_state *state,
> }
>
> load_non_regoff:
> + /*
> + * If src_tsr->kind is TSR_KIND_PERCPU_BASE, treat it as an array.
> + * No special handling is needed here; just fall through to retry
> + * and resolve the type from the second register.
> + */
> +
> /* Try another register if any */
> if (src->multi_regs && src->reg1 != src->reg2 && sreg != src->reg2 &&
> !(src->extend_type || src->shift_type)) {
> @@ -967,6 +984,34 @@ static void update_add_insn_state(struct type_state *state,
> }
>
> add_non_regoff:
> + if (src_tsr.kind == TSR_KIND_PERCPU_BASE) {
After fixing the issue mentioned by Sashiko (by adding recognition and handling in
arch_get_reg_offset for when reg2 is TSR_KIND_PERCPU_BASE [1]), this branch no longer
really needs explicit handling -- it can simply fall back to swapping the registers
and retrying (just like the handling for store). I plan to remove it in v7.
[1] https://lore.kernel.org/all/0c0c6282-efd6-4baf-9b98-3a5bb72b5067@huaweicloud.com/
Thanks,
Tengda
> + int reg2;
> +
> + if (!src->multi_regs) {
> + invalidate_reg_state(tsr);
> + return;
> + }
> +
> + reg2 = (sreg == src->reg1) ? src->reg2 : src->reg1;
> +
> + if (!has_reg_type(state, reg2) || !state->regs[reg2].ok) {
> + invalidate_reg_state(tsr);
> + return;
> + }
> +
> + /* Treat percpu as array: inherit type from reg2 */
> + tsr->type = state->regs[reg2].type;
> + tsr->kind = state->regs[reg2].kind;
> + tsr->offset = state->regs[reg2].offset;
> + tsr->imm_value = state->regs[reg2].imm_value;
> + tsr->ok = state->regs[reg2].ok;
> +
> + pr_debug_dtp("add [%x] percpu (reg%d, reg%d) -> reg%d",
> + insn_offset, src->reg1, src->reg2, dreg);
> + pr_debug_type_name(&tsr->type, tsr->kind);
> + return;
> + }
> +
> /* Try another register if any */
> if (src->multi_regs && src->reg1 != src->reg2 && sreg != src->reg2 &&
> !(src->extend_type || src->shift_type)) {
> diff --git a/tools/perf/util/annotate-data.c b/tools/perf/util/annotate-data.c
> index 592ad8b1bc96..a2434b978ec7 100644
> --- a/tools/perf/util/annotate-data.c
> +++ b/tools/perf/util/annotate-data.c
> @@ -1342,11 +1342,31 @@ static enum type_match_result check_matching_type(struct type_state *state,
> }
>
> if (state->regs[reg].kind == TSR_KIND_PERCPU_BASE) {
> - u64 var_addr = (s64) offset;
> + u64 var_addr;
> int var_offset;
>
> pr_debug_dtp("percpu var");
>
> + if (arch__is_arm64(dloc->arch)) {
> + int reg2;
> +
> + if (!retry || !dloc->op->multi_regs ||
> + dloc->op->reg1 == dloc->op->reg2 ||
> + dloc->op->extend_type || dloc->op->shift_type)
> + return PERF_TMR_BAIL_OUT;
> +
> + reg2 = dloc->op->reg2;
> + if (!has_reg_type(state, reg2) || !state->regs[reg2].ok)
> + return PERF_TMR_NO_TYPE;
> +
> + pr_debug_dtp(" : retry\n");
> + retry = false;
> + reg = reg2;
> + goto again;
> + }
> +
> + var_addr = (s64) offset;
> +
> if (dloc->op->multi_regs) {
> int reg2 = dloc->op->reg2;
>
next prev parent reply other threads:[~2026-09-20 1:52 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 1:29 [PATCH v6 00/26] perf arm64: Support data type profiling Tengda Wu
2026-09-16 1:29 ` [PATCH v6 01/26] perf capstone: Symbolize address operands to match objdump on arm64 Tengda Wu
2026-09-19 7:03 ` Namhyung Kim
2026-09-16 1:29 ` [PATCH v6 02/26] perf llvm: Fix arm64 adrp instruction disassembly mismatch with objdump Tengda Wu
2026-09-16 1:29 ` [PATCH v6 03/26] perf annotate-arm64: Generalize arm64_mov__parse to support more instructions Tengda Wu
2026-09-16 1:29 ` [PATCH v6 04/26] perf annotate-arm64: Handle load and store instructions Tengda Wu
2026-09-16 1:29 ` [PATCH v6 05/26] perf annotate: Normalize arch__dwarf_regnum() error return values Tengda Wu
2026-09-16 1:29 ` [PATCH v6 06/26] perf annotate: Introduce extract_op_location callback for arch-specific parsing Tengda Wu
2026-09-16 1:29 ` [PATCH v6 07/26] perf dwarf-regs: Adapt get_dwarf_regnum() for arm64 Tengda Wu
2026-09-16 1:29 ` [PATCH v6 08/26] perf annotate: Adapt arch__dwarf_regnum() " Tengda Wu
2026-09-16 1:29 ` [PATCH v6 09/26] perf annotate-arm64: Implement extract_op_location() callback Tengda Wu
2026-09-16 1:29 ` [PATCH v6 10/26] perf annotate: Default to --itrace=i1i for data type profiling Tengda Wu
2026-09-16 1:29 ` [PATCH v6 11/26] perf arm-spe: Set default synthesized event period to 1 Tengda Wu
2026-09-16 1:29 ` [PATCH v6 12/26] perf annotate-data: Extract invalidate_reg_state() as a common helper Tengda Wu
2026-09-16 1:29 ` [PATCH v6 13/26] perf annotate-arm64: Enable instruction tracking support Tengda Wu
2026-09-16 1:29 ` [PATCH v6 14/26] perf annotate-data: Add arch_get_reg_offset helper Tengda Wu
2026-09-16 1:29 ` [PATCH v6 15/26] perf annotate-arm64: Track return type after call instructions Tengda Wu
2026-09-16 1:29 ` [PATCH v6 16/26] perf annotate-arm64: Support load instruction tracking Tengda Wu
2026-09-16 1:29 ` [PATCH v6 17/26] perf annotate-arm64: Support store " Tengda Wu
2026-09-16 1:29 ` [PATCH v6 18/26] perf annotate-data: Expand type_state_reg imm_value to u64 Tengda Wu
2026-09-16 1:29 ` [PATCH v6 19/26] perf annotate-data: Track imm_value for stack variables Tengda Wu
2026-09-16 1:29 ` [PATCH v6 20/26] perf annotate-x86: Delete stale stack state on store of untracked register Tengda Wu
2026-09-16 1:29 ` [PATCH v6 21/26] perf annotate-arm64: Support stack variable tracking Tengda Wu
2026-09-16 1:29 ` [PATCH v6 22/26] perf annotate-arm64: Support 'mov' instruction tracking Tengda Wu
2026-09-16 1:29 ` [PATCH v6 23/26] perf annotate-arm64: Support 'add' " Tengda Wu
2026-09-16 1:30 ` [PATCH v6 24/26] perf annotate-arm64: Support 'adrp' instruction to track global variables Tengda Wu
2026-09-16 1:30 ` [PATCH v6 25/26] perf annotate-arm64: Support per-cpu variable access tracking Tengda Wu
2026-09-20 1:52 ` Tengda Wu [this message]
2026-09-16 1:30 ` [PATCH v6 26/26] perf annotate-arm64: Support 'mrs' instruction to track 'current' pointer Tengda Wu
2026-09-16 4:17 ` [PATCH v6 00/26] perf arm64: Support data type profiling Ian Rogers
2026-09-16 11:36 ` Tengda Wu
2026-09-19 7:10 ` Namhyung Kim
2026-09-19 11:22 ` Arnaldo Melo
2026-09-19 17:41 ` Namhyung Kim
2026-09-20 2:02 ` Tengda Wu
2026-09-21 6:47 ` Arnaldo Carvalho de Melo
2026-09-21 7:08 ` Tengda Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11700d47-ac92-487e-a20e-9fb2efa74534@huaweicloud.com \
--to=wutengda@huaweicloud.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=kim.phillips@arm.com \
--cc=leo.yan@linux.dev \
--cc=lihuafei1@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=morbo@google.com \
--cc=namhyung@kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=peterz@infradead.org \
--cc=xueshuai@linux.alibaba.com \
--cc=zli94@ncsu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®