From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Melo <arnaldo.melo@gmail.com>
Cc: Tengda Wu <wutengda@huaweicloud.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
james.clark@linaro.org, xueshuai@linux.alibaba.com,
Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Peter Zijlstra <peterz@infradead.org>,
leo.yan@linux.dev, Li Huafei <lihuafei1@huawei.com>,
Kim Phillips <kim.phillips@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ingo Molnar <mingo@redhat.com>, Bill Wendling <morbo@google.com>,
Nick Desaulniers <nick.desaulniers+lkml@gmail.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Zecheng Li <zli94@ncsu.edu>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev
Subject: Re: [PATCH v6 00/26] perf arm64: Support data type profiling
Date: Sat, 19 Sep 2026 10:41:48 -0700 [thread overview]
Message-ID: <aq7JXGyhWM5M6ubi@z2> (raw)
In-Reply-To: <EC6E525E-387A-493A-B720-80E6FB38B05B@gmail.com>
On Sat, Sep 19, 2026 at 08:22:01AM -0300, Arnaldo Melo wrote:
>
>
> On September 19, 2026 4:10:46 AM GMT-03:00, Namhyung Kim <namhyung@kernel.org> wrote:
> >Hello,
> >
> >On Wed, Sep 16, 2026 at 01:29:14AM +0000, Tengda Wu wrote:
> >> This patch series implements data type profiling support for arm64,
> >> enabling 'perf annotate --data-type' to resolve memory locations and
> >> variable types on arm64 platforms.
> >>
> >> The main changes since v5 include:
> >> v5: https://lore.kernel.org/all/cover.1788872630.git.wutengda@huaweicloud.com/
> >>
> >> * __get_dwarf_regnum_arm64 optimization: compute directly based on character
> >> judgment, avoiding strtol calls. (Ian Rogers)
> >>
> >> * extract_op_location_arm64 issue fix: support parsing instructions such as
> >> 'cmp x0, x1, lsl #3'.
> >>
> >> * Instruction tracking part, fixing issues pointed out by Sashiko, including:
> >> - adding TSR_KIND_POINTER handling for ldr.
> >> - premature returns in add and ldr causing percpu handling to be skipped.
> >> - adding a reg != -1 check for stack type propagation, etc.
> >>
> >> Patch organization
> >> ==================
> >>
> >> The series is organized as follows:
> >>
> >> 1. Fix disassembly mismatches (Patches 01-02)
> >> Current perf annotate supports three disassembly backends: llvm,
> >> capstone, and objdump. On arm64, inconsistencies between the output
> >> of these backends (specifically llvm/capstone vs. objdump) often
> >> prevent the tracker from correctly identifying registers and offsets.
> >> These patches resolve these mismatches, ensuring consistent instruction
> >> parsing across all supported backends.
> >>
> >> 2. Infrastructure for arm64 operand parsing (Patches 03-09)
> >> These patches establish the necessary infrastructure for arm64-specific
> >> operand handling. This includes implementing new callbacks and data
> >> structures to manage arm64's unique addressing modes and register sets.
> >> This foundation is essential for the subsequent type-tracking logic.
> >>
> >> 3. ARM SPE event handling (Patches 10-11)
> >> Patch 10 automatically deduplicates overlapping ARM SPE events (e.g.,
> >> l1d-miss, tlb-access) in 'perf annotate' by retaining only the
> >> "instructions" event when data type profiling is enabled. Patch 11
> >> defaults the synthesized event period to 1 for ARM SPE to fix zero
> >> 'Percent' values in annotate output.
> >
> >Thanks for working on this!
> >
> >I think it's ready to merge up to this point.
>
> You mean patches 1-11?
Yes.
Thanks,
Namhyung
next prev parent reply other threads:[~2026-09-19 17:41 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 1:29 Tengda Wu
2026-09-16 1:29 ` [PATCH v6 01/26] perf capstone: Symbolize address operands to match objdump on arm64 Tengda Wu
2026-09-19 7:03 ` Namhyung Kim
2026-09-16 1:29 ` [PATCH v6 02/26] perf llvm: Fix arm64 adrp instruction disassembly mismatch with objdump Tengda Wu
2026-09-16 1:29 ` [PATCH v6 03/26] perf annotate-arm64: Generalize arm64_mov__parse to support more instructions Tengda Wu
2026-09-16 1:29 ` [PATCH v6 04/26] perf annotate-arm64: Handle load and store instructions Tengda Wu
2026-09-16 1:29 ` [PATCH v6 05/26] perf annotate: Normalize arch__dwarf_regnum() error return values Tengda Wu
2026-09-16 1:29 ` [PATCH v6 06/26] perf annotate: Introduce extract_op_location callback for arch-specific parsing Tengda Wu
2026-09-16 1:29 ` [PATCH v6 07/26] perf dwarf-regs: Adapt get_dwarf_regnum() for arm64 Tengda Wu
2026-09-16 1:29 ` [PATCH v6 08/26] perf annotate: Adapt arch__dwarf_regnum() " Tengda Wu
2026-09-16 1:29 ` [PATCH v6 09/26] perf annotate-arm64: Implement extract_op_location() callback Tengda Wu
2026-09-16 1:29 ` [PATCH v6 10/26] perf annotate: Default to --itrace=i1i for data type profiling Tengda Wu
2026-09-16 1:29 ` [PATCH v6 11/26] perf arm-spe: Set default synthesized event period to 1 Tengda Wu
2026-09-16 1:29 ` [PATCH v6 12/26] perf annotate-data: Extract invalidate_reg_state() as a common helper Tengda Wu
2026-09-16 1:29 ` [PATCH v6 13/26] perf annotate-arm64: Enable instruction tracking support Tengda Wu
2026-09-16 1:29 ` [PATCH v6 14/26] perf annotate-data: Add arch_get_reg_offset helper Tengda Wu
2026-09-16 1:29 ` [PATCH v6 15/26] perf annotate-arm64: Track return type after call instructions Tengda Wu
2026-09-16 1:29 ` [PATCH v6 16/26] perf annotate-arm64: Support load instruction tracking Tengda Wu
2026-09-16 1:29 ` [PATCH v6 17/26] perf annotate-arm64: Support store " Tengda Wu
2026-09-16 1:29 ` [PATCH v6 18/26] perf annotate-data: Expand type_state_reg imm_value to u64 Tengda Wu
2026-09-16 1:29 ` [PATCH v6 19/26] perf annotate-data: Track imm_value for stack variables Tengda Wu
2026-09-16 1:29 ` [PATCH v6 20/26] perf annotate-x86: Delete stale stack state on store of untracked register Tengda Wu
2026-09-16 1:29 ` [PATCH v6 21/26] perf annotate-arm64: Support stack variable tracking Tengda Wu
2026-09-16 1:29 ` [PATCH v6 22/26] perf annotate-arm64: Support 'mov' instruction tracking Tengda Wu
2026-09-16 1:29 ` [PATCH v6 23/26] perf annotate-arm64: Support 'add' " Tengda Wu
2026-09-16 1:30 ` [PATCH v6 24/26] perf annotate-arm64: Support 'adrp' instruction to track global variables Tengda Wu
2026-09-16 1:30 ` [PATCH v6 25/26] perf annotate-arm64: Support per-cpu variable access tracking Tengda Wu
2026-09-20 1:52 ` Tengda Wu
2026-09-16 1:30 ` [PATCH v6 26/26] perf annotate-arm64: Support 'mrs' instruction to track 'current' pointer Tengda Wu
2026-09-16 4:17 ` [PATCH v6 00/26] perf arm64: Support data type profiling Ian Rogers
2026-09-16 11:36 ` Tengda Wu
2026-09-19 7:10 ` Namhyung Kim
2026-09-19 11:22 ` Arnaldo Melo
2026-09-19 17:41 ` Namhyung Kim [this message]
2026-09-20 2:02 ` Tengda Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aq7JXGyhWM5M6ubi@z2 \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=arnaldo.melo@gmail.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=kim.phillips@arm.com \
--cc=leo.yan@linux.dev \
--cc=lihuafei1@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=morbo@google.com \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=peterz@infradead.org \
--cc=wutengda@huaweicloud.com \
--cc=xueshuai@linux.alibaba.com \
--cc=zli94@ncsu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®