From: Johannes Berg <johannes@sipsolutions.net>
To: jt@hpl.hp.com
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
"David S. Miller" <davem@davemloft.net>,
Linux kernel mailing list <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 2.6.20] kobject net ifindex + rename
Date: Wed, 28 Feb 2007 10:16:05 +0100 [thread overview]
Message-ID: <1172654165.3681.31.camel@johannes.berg> (raw)
In-Reply-To: <20070228012741.GA3988@bougret.hpl.hp.com>
[-- Attachment #1: Type: text/plain, Size: 784 bytes --]
Hi,
> Patch for 2.6.20 is attached.
... and in the meantime netdevices aren't class_device any more :) IOW,
your patch isn't going to work any more. Also, I think wireless could
benefit from this as well.
> The kobject framework is well designed, so adding these
> features is trivial change and won't run the risk of breaking anything
> (famous last words). Obviously, hotplug apps are free to ignore those
> additional features.
Why not just add this to base kobject_rename instead? That way,
userspace is notified for all renames in sysfs.
The patch then collapses down to the change in net's sysfs code to add
the ifindex to the environment, and another change in kobject to invoke
a new event when a name changes and show the old name.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]
next prev parent reply other threads:[~2007-02-28 9:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-28 1:27 Jean Tourrilhes
2007-02-28 9:16 ` Johannes Berg [this message]
2007-02-28 18:51 ` Jean Tourrilhes
2007-02-28 19:03 ` Johannes Berg
2007-02-28 9:34 ` Jarek Poplawski
2007-02-28 9:52 ` Jarek Poplawski
2007-02-28 18:45 ` Jean Tourrilhes
2007-03-01 7:42 ` Jarek Poplawski
2007-03-01 19:27 ` Jean Tourrilhes
2007-03-02 9:18 ` Jarek Poplawski
2007-02-28 15:36 ` Greg KH
2007-02-28 18:43 ` Jean Tourrilhes
2007-03-01 0:26 ` Jean Tourrilhes
2007-03-01 0:37 ` Johannes Berg
2007-03-01 0:51 ` Jean Tourrilhes
2007-03-01 0:57 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1172654165.3681.31.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=davem@davemloft.net \
--cc=gregkh@suse.de \
--cc=jt@hpl.hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®