From: Johannes Berg <johannes@sipsolutions.net>
To: jt@hpl.hp.com
Cc: Greg KH <gregkh@suse.de>, Jarek Poplawski <jarkao2@o2.pl>,
"David S. Miller" <davem@davemloft.net>,
Linux kernel mailing list <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH 2.6.20] kobject net ifindex + rename
Date: Thu, 01 Mar 2007 01:57:40 +0100 [thread overview]
Message-ID: <1172710660.11911.13.camel@johannes.berg> (raw)
In-Reply-To: <20070301005123.GA7116@bougret.hpl.hp.com>
[-- Attachment #1: Type: text/plain, Size: 754 bytes --]
On Wed, 2007-02-28 at 16:51 -0800, Jean Tourrilhes wrote:
> I would prefer to fix the comment when this change actually
> happens. I prefer comments to refer to the current reality, rather
> than past/future situation.
Uh, no. device_rename is perfectly fine, even other people may use it in
the future.
> When you introduce wireless renaming, you
> will need to verify the whole chain anyway, so you might as well fix
> the comment while merging wireless renaming.
No again, device_rename is perfectly fine API, I shouldn't have to look
at it's internals to see if it's broken in my use case. Even if it's
only a broken comment.
I'm not going to respin your patches though, if this doesn't make it in
I don't care.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]
prev parent reply other threads:[~2007-03-01 0:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-28 1:27 Jean Tourrilhes
2007-02-28 9:16 ` Johannes Berg
2007-02-28 18:51 ` Jean Tourrilhes
2007-02-28 19:03 ` Johannes Berg
2007-02-28 9:34 ` Jarek Poplawski
2007-02-28 9:52 ` Jarek Poplawski
2007-02-28 18:45 ` Jean Tourrilhes
2007-03-01 7:42 ` Jarek Poplawski
2007-03-01 19:27 ` Jean Tourrilhes
2007-03-02 9:18 ` Jarek Poplawski
2007-02-28 15:36 ` Greg KH
2007-02-28 18:43 ` Jean Tourrilhes
2007-03-01 0:26 ` Jean Tourrilhes
2007-03-01 0:37 ` Johannes Berg
2007-03-01 0:51 ` Jean Tourrilhes
2007-03-01 0:57 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1172710660.11911.13.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=davem@davemloft.net \
--cc=gregkh@suse.de \
--cc=jarkao2@o2.pl \
--cc=jt@hpl.hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®