From: Thomas Gleixner <tglx@linutronix.de>
To: Chuck Ebbert <cebbert@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Johannes Bauer <JohannesBauer@gmx.de>,
linux-kernel@vger.kernel.org, schwab@suse.de,
Stable Kernel Team <stable@kernel.org>, Greg KH <greg@kroah.com>,
Adrian Bunk <bunk@stusta.de>, Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] hrtimer: prevent overrun DoS in hrtimer_forward()
Date: Sun, 18 Mar 2007 22:32:59 +0100 [thread overview]
Message-ID: <1174253579.13341.477.camel@localhost.localdomain> (raw)
In-Reply-To: <45FDAC3B.6000202@redhat.com>
On Sun, 2007-03-18 at 17:16 -0400, Chuck Ebbert wrote:
> Thomas Gleixner wrote:
> >
> > I'd prefer this one: The maximum seconds value we can handle on 32bit is
> > LONG_MAX.
> >
> > diff --git a/include/linux/ktime.h b/include/linux/ktime.h
> > index c68c7ac..248305b 100644
> > --- a/include/linux/ktime.h
> > +++ b/include/linux/ktime.h
> > @@ -57,7 +57,11 @@ typedef union {
> > } ktime_t;
> >
> > #define KTIME_MAX ((s64)~((u64)1 << 63))
> > -#define KTIME_SEC_MAX (KTIME_MAX / NSEC_PER_SEC)
> > +#if (BITS_PER_LONG == 64)
> > +# define KTIME_SEC_MAX (KTIME_MAX / NSEC_PER_SEC)
> > +#else
> > +# define KTIME_SEC_MAX LONG_MAX
> > +#endif
> >
> > /*
> > * ktime_t definitions when using the 64-bit scalar representation:
> >
>
> Just to be clear: this replaces the earlier patch, right?
This replaces the fix Andrew did.
http://marc.info/?l=linux-kernel&m=117407812411997&w=2
tglx
next prev parent reply other threads:[~2007-03-18 21:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-13 18:55 x86_64 system lockup from userspace using setitimer() Johannes Bauer
2007-03-13 19:19 ` Andreas Schwab
2007-03-13 20:02 ` Chuck Ebbert
2007-03-13 20:33 ` Thomas Gleixner
2007-03-14 10:00 ` [PATCH] hrtimer: prevent overrun DoS in hrtimer_forward() Thomas Gleixner
2007-03-14 10:08 ` Ingo Molnar
2007-03-16 20:43 ` Andrew Morton
2007-03-16 21:05 ` Thomas Gleixner
2007-03-18 21:16 ` Chuck Ebbert
2007-03-18 21:32 ` Thomas Gleixner [this message]
2007-03-18 21:53 ` Chuck Ebbert
2007-03-18 22:04 ` Thomas Gleixner
2007-03-18 22:02 ` Chuck Ebbert
2007-04-04 21:11 ` Adrian Bunk
2007-04-04 21:30 ` Thomas Gleixner
2007-04-09 13:01 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1174253579.13341.477.camel@localhost.localdomain \
--to=tglx@linutronix.de \
--cc=JohannesBauer@gmx.de \
--cc=akpm@linux-foundation.org \
--cc=bunk@stusta.de \
--cc=cebbert@redhat.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=schwab@suse.de \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome