From: Thomas Gleixner <tglx@linutronix.de>
To: Adrian Bunk <bunk@stusta.de>
Cc: Chuck Ebbert <cebbert@redhat.com>,
Johannes Bauer <JohannesBauer@gmx.de>,
linux-kernel@vger.kernel.org, schwab@suse.de,
Stable Kernel Team <stable@kernel.org>, Greg KH <greg@kroah.com>,
Andrew Morton <akpm@osdl.org>, Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] hrtimer: prevent overrun DoS in hrtimer_forward()
Date: Wed, 04 Apr 2007 23:30:48 +0200 [thread overview]
Message-ID: <1175722249.28263.343.camel@localhost.localdomain> (raw)
In-Reply-To: <20070404211159.GT27660@stusta.de>
On Wed, 2007-04-04 at 23:11 +0200, Adrian Bunk wrote:
> On Wed, Mar 14, 2007 at 11:00:12AM +0100, Thomas Gleixner wrote:
> > hrtimer_forward() does not check for the possible overflow of
> > timer->expires. This can happen on 64 bit machines with large interval
> > values and results currently in an endless loop in the softirq because
> > the expiry value becomes negative and therefor the timer is expired all
> > the time.
> >
> > Check for this condition and set the expiry value to the max. expiry
> > time in the future.
> >
> > The fix should be applied to stable kernel series as well.
>
>
> Is this relevant for 2.6.16?
>
> I'm asking since KTIME_SEC_MAX is not used in 2.6.16, and therefore the
> check in ktime_set() is also missing.
KTIME_SEC_MAX was introduced with commit
96dd7421a06a5bc6eb731323b95efcb2fd864854
to fix a conversion problem on 64 bit machines, which is also present in
2.6.16 AFAICT.
The patch just makes use of this constant. So you need to pull it as
well.
tglx
next prev parent reply other threads:[~2007-04-04 21:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-13 18:55 x86_64 system lockup from userspace using setitimer() Johannes Bauer
2007-03-13 19:19 ` Andreas Schwab
2007-03-13 20:02 ` Chuck Ebbert
2007-03-13 20:33 ` Thomas Gleixner
2007-03-14 10:00 ` [PATCH] hrtimer: prevent overrun DoS in hrtimer_forward() Thomas Gleixner
2007-03-14 10:08 ` Ingo Molnar
2007-03-16 20:43 ` Andrew Morton
2007-03-16 21:05 ` Thomas Gleixner
2007-03-18 21:16 ` Chuck Ebbert
2007-03-18 21:32 ` Thomas Gleixner
2007-03-18 21:53 ` Chuck Ebbert
2007-03-18 22:04 ` Thomas Gleixner
2007-03-18 22:02 ` Chuck Ebbert
2007-04-04 21:11 ` Adrian Bunk
2007-04-04 21:30 ` Thomas Gleixner [this message]
2007-04-09 13:01 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1175722249.28263.343.camel@localhost.localdomain \
--to=tglx@linutronix.de \
--cc=JohannesBauer@gmx.de \
--cc=akpm@osdl.org \
--cc=bunk@stusta.de \
--cc=cebbert@redhat.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=schwab@suse.de \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome