mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Wu, Bryan" <bryan.wu@analog.com>
To: David Brownell <david-b@pacbell.net>,
	jie.zhang@analog.com, roy.huang@analog.com
Cc: bryan.wu@analog.com, linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] USB gadget rndis: fix bug skb_push function may return an unaligned pointer bug
Date: Fri, 06 Apr 2007 10:25:18 +0800	[thread overview]
Message-ID: <1175826318.17315.57.camel@roc-desktop> (raw)
In-Reply-To: <200704051429.04147.david-b@pacbell.net>

On Thu, 2007-04-05 at 14:29 -0700, David Brownell wrote:
> On Tuesday 03 April 2007 11:28 pm, Wu, Bryan wrote:
> > USB gadget rndis: skb_push function may return a pointer which is not
> > aligned as required by struct rndis_packet_msg_type.
> 
> Can you instead try to update the declaration of that struct
> so that it's "__attribute__((packed))"?  That's less invasive,
> and will address similar issues elsewhere ...
> 
> - Dave

OK, Jie and Roy will try to use this __attribute__ method and test it on
blackfin platform. Sorry for missing their "Signed-off-by". I will
resend a patch later for review.

Thanks
-Bryan


  reply	other threads:[~2007-04-06  2:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-04  6:28 Wu, Bryan
2007-04-05 21:29 ` David Brownell
2007-04-06  2:25   ` Wu, Bryan [this message]
2007-04-06  4:02     ` [PATCH] USB gadget rndis: fix struct rndis_packet_msg_type unaligned bug Wu, Bryan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1175826318.17315.57.camel@roc-desktop \
    --to=bryan.wu@analog.com \
    --cc=akpm@linux-foundation.org \
    --cc=david-b@pacbell.net \
    --cc=jie.zhang@analog.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roy.huang@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome