mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Wu, Bryan" <bryan.wu@analog.com>
To: David Brownell <david-b@pacbell.net>,
	jie.zhang@analog.com, roy.huang@analog.com,
	linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	bryan.wu@analog.com
Subject: [PATCH] USB gadget rndis: fix struct rndis_packet_msg_type unaligned bug
Date: Fri, 06 Apr 2007 12:02:49 +0800	[thread overview]
Message-ID: <1175832169.17315.61.camel@roc-desktop> (raw)
In-Reply-To: <1175826318.17315.57.camel@roc-desktop>

[PATCH] usb gadget rndis: 
skb_push function may return a pointer which is not aligned as required
by struct rndis_packet_msg_type. Using attribute trick to fix this bug.

Signed-off-by: Roy Huang <roy.huang@analog.com>
Signed-off-by: Jie Zhang <jie.zhang@analog.com>
Signed-off-by: Bryan Wu <bryan.wu@analog.com>
---
 drivers/usb/gadget/rndis.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/usb/gadget/rndis.h b/drivers/usb/gadget/rndis.h
index 4c3c725..397b149 100644
--- a/drivers/usb/gadget/rndis.h
+++ b/drivers/usb/gadget/rndis.h
@@ -195,7 +195,7 @@ struct rndis_packet_msg_type
 	__le32	PerPacketInfoLength;
 	__le32	VcHandle;
 	__le32	Reserved;
-};
+} __attribute__ ((packed));
 
 struct rndis_config_parameter
 {
-- 
1.5.0.5


      reply	other threads:[~2007-04-06  4:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-04  6:28 [PATCH] USB gadget rndis: fix bug skb_push function may return an unaligned pointer bug Wu, Bryan
2007-04-05 21:29 ` David Brownell
2007-04-06  2:25   ` Wu, Bryan
2007-04-06  4:02     ` Wu, Bryan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1175832169.17315.61.camel@roc-desktop \
    --to=bryan.wu@analog.com \
    --cc=akpm@linux-foundation.org \
    --cc=david-b@pacbell.net \
    --cc=jie.zhang@analog.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roy.huang@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome